Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2492233003: Reland of "Remove mutex locks in SchemeRegistry" (Closed)

Created:
4 years, 1 month ago by Charlie Harrison
Modified:
4 years ago
Reviewers:
kinuko
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, tkent
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "Remove mutex locks in SchemeRegistry" This reverts commit b27e567c51940289e0a989cc65f4696739d5936a (https://codereview.chromium.org/2498623002/) which previously landed as 087c8b21705dd47c9a71058bf743147324425585 (https://codereview.chromium.org/2474303004/) BUG=348655 Committed: https://crrev.com/8786fd7ee3dae56e283dc50467675f668cd8c3a6 Cr-Commit-Position: refs/heads/master@{#434246}

Patch Set 1 #

Patch Set 2 : Revert "Revert of Remove mutex locks in SchemeRegistry (patchset #5 id:80001 of https://codereview.… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -78 lines) Patch
M third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp View 1 22 chunks +64 lines, -78 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Charlie Harrison
kinuko: shall we try this again? I asked blink-dev for advice here [1] and decided ...
4 years ago (2016-11-23 02:10:57 UTC) #2
kinuko
Yep, it's not too pretty but this makes sense too. lgtm
4 years ago (2016-11-23 10:22:51 UTC) #3
Charlie Harrison
Thanks!
4 years ago (2016-11-23 17:14:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492233003/20001
4 years ago (2016-11-23 17:14:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-23 21:04:38 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-23 21:07:10 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8786fd7ee3dae56e283dc50467675f668cd8c3a6
Cr-Commit-Position: refs/heads/master@{#434246}

Powered by Google App Engine
This is Rietveld 408576698