update shared library extension on AIX to .a

update shared library extension on AIX to .a

BUG=

[Dirk Pranke, 2016-11-11 17:46:06]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-11-11 17:46:07]

lgtm.

I had either forgotten or didn't know that AIX defaulted to .a . It looks like
if you pass -btrl to the linker it'll also look for .so. I'm not suggesting that
you make that change instead, but I'm wondering if you know any reasons one
approach might be better than the other?

[sxa, 2016-11-14 12:59:46]

On 2016/11/11 17:46:07, Dirk Pranke wrote:
> I had either forgotten or didn't know that AIX defaulted to .a . It looks like
> if you pass -btrl to the linker it'll also look for .so. I'm not suggesting
that
> you make that change instead, but I'm wondering if you know any reasons one
> approach might be better than the other?

My main reason for choosing this option was just that it was consistent with the
default operation on the platform and it felt right to stick to that convention.
I would imagine both options would work.

[sxa, 2016-11-14 13:01:22]

Looks like the try jobs have failed although so have all the recent ones and
while I can't see the logs of the other recent ones it doesn't appear that
there's
anything that's o0bviously failed as a direct result of my changes (not that
they
should since they're AIX specific changes!)

[Dirk Pranke, 2016-11-14 17:38:22]

Yup, I'll try to land this today.

[Dirk Pranke, 2016-11-14 21:28:38]

https://codereview.chromium.org/2492233002/diff/1/pylib/gyp/generator/make.py
File pylib/gyp/generator/make.py (right):

https://codereview.chromium.org/2492233002/diff/1/pylib/gyp/generator/make.py...
pylib/gyp/generator/make.py:1: # Copyright (c) 2016 The Chromium Authors. All
rights reserved.
I *think* this needs to stay as Google, actually, and we should add IBM to the
AUTHORS file.

Also, we should not change the copyright year (the year represents when the file
was created, not when it was last modified).

Does that work for you?

[Lei Zhang, 2016-11-14 21:34:25]

Description was changed from

==========
update shared libary extension on AIX to .a

BUG=
==========

to

==========
update shared library extension on AIX to .a

BUG=
==========

[Lei Zhang, 2016-11-14 21:35:06]

(Drive by) Fixed a typo in the CL description.

[sxa, 2016-11-17 11:44:18]

Works for me but the presubmit checks failed because I hadn't put the "new"
Chromium
Authors copyright message in which is why I updated it - unsure if it's possible
to
bypass that. Is the AUTHORS file something I should update or would you do that?

[Dirk Pranke, 2016-11-17 18:40:18]

On 2016/11/17 11:44:18, sxa wrote:
> Works for me but the presubmit checks failed because I hadn't put the "new"
> Chromium
> Authors copyright message in which is why I updated it - unsure if it's
possible
> to
> bypass that. Is the AUTHORS file something I should update or would you do
that?

I'll double check and land something one way or another.

[Dirk Pranke, 2016-11-17 23:46:28]

I'm closing this since I landed a modified version of it in
https://codereview.chromium.org/2511733005/ .