Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2492223002:
Fix compile errors in GL context creation for ozone and wayland. (Closed)
|
Created:
4 years, 1 month ago by Geoff Lang Modified:
4 years, 1 month ago CC:
chromium-reviews, kalyank, kylechar, ozone-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix compile errors in GL context creation for ozone and wayland.
Failures were introduced in https://codereview.chromium.org/2480373002/
BUG=angleproject:1518
Committed: https://crrev.com/a56adaccac936ab70c81d89dd66cb9088a8325fa
Cr-Commit-Position: refs/heads/master@{#431901}
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 27 (15 generated)
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
geofflang@chromium.org changed reviewers: + reveman@chromium.org, rjkroege@chromium.org
PTAL, looks like I broke the builds on a couple non-default bots. Any trybots that are known to build these targets?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix compile errors in GL context creation for ozone and wayland. Failures were introduced in https://codereview.chromium.org/2480373002/ BUG=angleproject:1518 ========== to ========== Fix compile errors in GL context creation for ozone and wayland. Failures were introduced in https://codereview.chromium.org/2480373002/ BUG=angleproject:1518 ==========
thomasanderson@google.com changed reviewers: + thomasanderson@google.com
lgtm
On 2016/11/11 15:18:16, Geoff Lang wrote: > PTAL, looks like I broke the builds on a couple non-default bots. Any trybots > that are known to build these targets? Hi Geoff. You're using the correct trybot, but I forgot to set up the mb config for it. I've created https://codereview.chromium.org/2499663002/, and you can try rerunning the trybot once that CL lands :)
looks like the bot is green now lgtm
The CQ bit was checked by geofflang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for components/exo/wayland/clients/motion_events.cc:
While running git apply --index -p1;
error: patch failed: components/exo/wayland/clients/motion_events.cc:351
error: components/exo/wayland/clients/motion_events.cc: patch does not apply
Patch: components/exo/wayland/clients/motion_events.cc
Index: components/exo/wayland/clients/motion_events.cc
diff --git a/components/exo/wayland/clients/motion_events.cc
b/components/exo/wayland/clients/motion_events.cc
index
f32b13059bddc06cbf2560db083b4f30f4592c03..d0e8d6466744d92a88d4e68ae935cd036c9f9ccf
100644
--- a/components/exo/wayland/clients/motion_events.cc
+++ b/components/exo/wayland/clients/motion_events.cc
@@ -351,7 +351,7 @@ int MotionEvents::Run() {
gl_surface_ = gl::init::CreateOffscreenGLSurface(gfx::Size());
gl_context_ =
gl::init::CreateGLContext(nullptr, // share_group
- gl_surface_.get(), gl::PreferIntegratedGpu);
+ gl_surface_.get(), gl::GLContextAttribs());
make_current_.reset(
new ui::ScopedMakeCurrent(gl_context_.get(), gl_surface_.get()));
The CQ bit was checked by geofflang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rjkroege@chromium.org, reveman@chromium.org, thomasanderson@google.com Link to the patchset: https://codereview.chromium.org/2492223002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix compile errors in GL context creation for ozone and wayland. Failures were introduced in https://codereview.chromium.org/2480373002/ BUG=angleproject:1518 ========== to ========== Fix compile errors in GL context creation for ozone and wayland. Failures were introduced in https://codereview.chromium.org/2480373002/ BUG=angleproject:1518 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix compile errors in GL context creation for ozone and wayland. Failures were introduced in https://codereview.chromium.org/2480373002/ BUG=angleproject:1518 ========== to ========== Fix compile errors in GL context creation for ozone and wayland. Failures were introduced in https://codereview.chromium.org/2480373002/ BUG=angleproject:1518 Committed: https://crrev.com/a56adaccac936ab70c81d89dd66cb9088a8325fa Cr-Commit-Position: refs/heads/master@{#431901} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a56adaccac936ab70c81d89dd66cb9088a8325fa Cr-Commit-Position: refs/heads/master@{#431901} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
