Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2492123003: [inspector] Add test case for wasm source (Closed)

Created:
4 years, 1 month ago by Clemens Hammacher
Modified:
4 years, 1 month ago
Reviewers:
kozy, Yang
CC:
devtools-reviews_chromium.org, titzer, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Add test case for wasm source The test just prints the source text of each line on the stack. Look how beautiful it reads \o/ BUG=chromium:659715 R=yangguo@chromium.org, kozyatinskiy@chromium.org CC=titzer@chromium.org Committed: https://crrev.com/8c4224a5967500407850eb66da07fede8fb18df6 Cr-Commit-Position: refs/heads/master@{#41068}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Alexey's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -0 lines) Patch
A test/inspector/debugger/wasm-source.js View 1 1 chunk +79 lines, -0 lines 0 comments Download
A test/inspector/debugger/wasm-source-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (11 generated)
Clemens Hammacher
4 years, 1 month ago (2016-11-11 05:12:55 UTC) #5
Yang
lgtm
4 years, 1 month ago (2016-11-15 07:51:56 UTC) #6
kozy
https://codereview.chromium.org/2492123003/diff/1/test/inspector/debugger/wasm-source.js File test/inspector/debugger/wasm-source.js (right): https://codereview.chromium.org/2492123003/diff/1/test/inspector/debugger/wasm-source.js#newcode68 test/inspector/debugger/wasm-source.js:68: .then((sourceMessage) => { Please extract this arrow function to ...
4 years, 1 month ago (2016-11-15 23:10:53 UTC) #7
Clemens Hammacher
https://codereview.chromium.org/2492123003/diff/1/test/inspector/debugger/wasm-source.js File test/inspector/debugger/wasm-source.js (right): https://codereview.chromium.org/2492123003/diff/1/test/inspector/debugger/wasm-source.js#newcode68 test/inspector/debugger/wasm-source.js:68: .then((sourceMessage) => { On 2016/11/15 at 23:10:53, kozyatinskiy wrote: ...
4 years, 1 month ago (2016-11-16 11:58:01 UTC) #10
kozy
thanks, lgtm
4 years, 1 month ago (2016-11-16 16:14:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492123003/20001
4 years, 1 month ago (2016-11-17 10:14:48 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 10:17:10 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:37:56 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c4224a5967500407850eb66da07fede8fb18df6
Cr-Commit-Position: refs/heads/master@{#41068}

Powered by Google App Engine
This is Rietveld 408576698