Source/core/rendering/svg/SVGRenderingContext.cpp - Issue 24921002: Make compositingState explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGRenderingContext.cpp

Issue 24921002: Make compositingState explicit (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed second round of reviewer feedback Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/SVGRenderingContext.cpp

diff --git a/Source/core/rendering/svg/SVGRenderingContext.cpp b/Source/core/rendering/svg/SVGRenderingContext.cpp

index 359351ecd2cb47a7907b3d3100406e7ced34dea8..16121049079ee5651c398bb1d4d318f75174cf5e 100644

--- a/Source/core/rendering/svg/SVGRenderingContext.cpp

+++ b/Source/core/rendering/svg/SVGRenderingContext.cpp

@@ -226,7 +226,9 @@ void SVGRenderingContext::calculateTransformationToOutermostCoordinateSystem(con

absoluteTransform = layerTransform->toAffineTransform() * absoluteTransform;

// We can stop at compositing layers, to match the backing resolution.

- if (layer->isComposited())

+ // FIXME: should we be computing the transform to the nearest composited layer,

+ // or the nearest composited layer that does not paint into its ancestor?

+ if (layer->compositedLayerMapping())

break;

layer = layer->parent();