Source/core/inspector/InspectorLayerTreeAgent.cpp - Issue 24921002: Make compositingState explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorLayerTreeAgent.cpp

Issue 24921002: Make compositingState explicit (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed second round of reviewer feedback Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/InspectorLayerTreeAgent.cpp

diff --git a/Source/core/inspector/InspectorLayerTreeAgent.cpp b/Source/core/inspector/InspectorLayerTreeAgent.cpp

index ca07ba42e7d1f97e5a312fa53733d5f990788fd4..6979bb61c7b83585c2330b0d8b6d1b51afb52846 100644

--- a/Source/core/inspector/InspectorLayerTreeAgent.cpp

+++ b/Source/core/inspector/InspectorLayerTreeAgent.cpp

@@ -204,7 +204,7 @@ void InspectorLayerTreeAgent::getLayers(ErrorString* errorString, const int* nod

void InspectorLayerTreeAgent::buildLayerIdToNodeIdMap(ErrorString* errorString, RenderLayer* root, LayerIdToNodeIdMap& layerIdToNodeIdMap)

{

- if (root->isComposited()) {

+ if (root->compositingState() == PaintsIntoOwnBacking || root->compositingState() == HasOwnBackingButPaintsIntoAncestor) {

Julien - ping for review 2013/10/07 18:26:24 Nit: compositedLayerMapping()?

if (Node* node = root->renderer()->generatingNode()) {

GraphicsLayer* graphicsLayer = root->compositedLayerMapping()->childForSuperlayers();

layerIdToNodeIdMap.set(graphicsLayer->platformLayer()->id(), idForNode(errorString, node));

« no previous file with comments | « Source/core/css/CSSComputedStyleDeclaration.cpp ('k') | Source/core/page/FrameView.cpp » ('j') | no next file with comments »