Source/core/rendering/RenderView.cpp - Issue 24921002: Make compositingState explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderView.cpp

Issue 24921002: Make compositingState explicit (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: addressed first round of reviewer comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderView.cpp

diff --git a/Source/core/rendering/RenderView.cpp b/Source/core/rendering/RenderView.cpp

index 1f427eacf263053278246ab6960bcd80c7260154..984af4719ea496aeb897199ad0f5d346e8c7caf2 100644

--- a/Source/core/rendering/RenderView.cpp

+++ b/Source/core/rendering/RenderView.cpp

@@ -438,11 +438,6 @@ void RenderView::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset)

paintObject(paintInfo, paintOffset);

}

-static inline bool isComposited(RenderObject* object)

- return object->hasLayer() && toRenderLayerModelObject(object)->layer()->isComposited();

static inline bool rendererObscuresBackground(RenderObject* rootObject)

{

if (!rootObject)

@@ -454,7 +449,7 @@ static inline bool rendererObscuresBackground(RenderObject* rootObject)

|| style->hasTransform())

return false;

- if (isComposited(rootObject))

+ if (rootObject->compositingState() == PaintsIntoOwnBacking)

return false;

const RenderObject* rootRenderer = rootObject->rendererForRootBackground();