Make compositingState explicit

Source/core/rendering/RenderObject.h

Index: Source/core/rendering/RenderObject.h
diff --git a/Source/core/rendering/RenderObject.h b/Source/core/rendering/RenderObject.h
index 2d024a480832f16eade7a90059429977bbed9f5a..f2055c307320318fa56d3176b6865527e7bdcbf4 100644
--- a/Source/core/rendering/RenderObject.h
+++ b/Source/core/rendering/RenderObject.h
@@ -30,6 +30,7 @@
 #include "core/dom/Position.h"
 #include "core/dom/StyleEngine.h"
 #include "core/fetch/ImageResourceClient.h"
+#include "core/rendering/CompositingState.h"
 #include "core/rendering/LayoutIndicator.h"
 #include "core/rendering/PaintPhase.h"
 #include "core/rendering/RenderObjectChildList.h"
@@ -698,7 +699,7 @@ public:
     virtual void addAnnotatedRegions(Vector<AnnotatedRegionValue>&);
     void collectAnnotatedRegions(Vector<AnnotatedRegionValue>&);
 
-    bool isComposited() const;
+    CompositingState compositingState() const;

[Julien - ping for review, 2013/10/03 20:08:36]

We discussed this over IM, I am not a huge fan of this change that exposes
internal details to non-rendering/ code but I don't think keeping isComposited()
is any better.

[shawnsingh, 2013/10/07 11:45:04]

I think the new version is slightly better because it forces people to recognize
the various states correctly.  As long as other code relies on knowing
compositing state, they may as well know it correctly =)

It should be our mission to gradually refactor the code so that this function
can be removed.

 
     bool hitTest(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestFilter = HitTestAll);
     virtual void updateHitTestResult(HitTestResult&, const LayoutPoint&);