Make compositingState explicit

Source/core/rendering/RenderBoxModelObject.cpp

Index: Source/core/rendering/RenderBoxModelObject.cpp
diff --git a/Source/core/rendering/RenderBoxModelObject.cpp b/Source/core/rendering/RenderBoxModelObject.cpp
index 932db84e2a01905a1926066b8f1bb04e49f1d64a..a1faaa05d1873f0a76a895e78c41492791c52786 100644
--- a/Source/core/rendering/RenderBoxModelObject.cpp
+++ b/Source/core/rendering/RenderBoxModelObject.cpp
@@ -102,49 +102,49 @@ bool RenderBoxModelObject::hasAcceleratedCompositing() const
 bool RenderBoxModelObject::startTransition(double timeOffset, CSSPropertyID propertyId, const RenderStyle* fromStyle, const RenderStyle* toStyle)
 {
     ASSERT(hasLayer());
-    ASSERT(isComposited());
+    ASSERT(compositingState() == PaintsIntoOwnBacking);
     return layer()->backing()->startTransition(timeOffset, propertyId, fromStyle, toStyle);
 }
 
 void RenderBoxModelObject::transitionPaused(double timeOffset, CSSPropertyID propertyId)
 {
     ASSERT(hasLayer());
-    ASSERT(isComposited());
+    ASSERT(compositingState() == PaintsIntoOwnBacking);
     layer()->backing()->transitionPaused(timeOffset, propertyId);
 }
 
 void RenderBoxModelObject::transitionFinished(CSSPropertyID propertyId)
 {
     ASSERT(hasLayer());
-    ASSERT(isComposited());
+    ASSERT(compositingState() == PaintsIntoOwnBacking);
     layer()->backing()->transitionFinished(propertyId);
 }
 
 bool RenderBoxModelObject::startAnimation(double timeOffset, const CSSAnimationData* animation, const KeyframeList& keyframes)
 {
     ASSERT(hasLayer());
-    ASSERT(isComposited());
+    ASSERT(compositingState() == PaintsIntoOwnBacking);
     return layer()->backing()->startAnimation(timeOffset, animation, keyframes);
 }
 
 void RenderBoxModelObject::animationPaused(double timeOffset, const String& name)
 {
     ASSERT(hasLayer());
-    ASSERT(isComposited());
+    ASSERT(compositingState() == PaintsIntoOwnBacking);
     layer()->backing()->animationPaused(timeOffset, name);
 }
 
 void RenderBoxModelObject::animationFinished(const String& name)
 {
     ASSERT(hasLayer());
-    ASSERT(isComposited());
+    ASSERT(compositingState() == PaintsIntoOwnBacking);
     layer()->backing()->animationFinished(name);
 }
 
 void RenderBoxModelObject::suspendAnimations(double time)
 {
     ASSERT(hasLayer());
-    ASSERT(isComposited());
+    ASSERT(compositingState() == PaintsIntoOwnBacking);
     layer()->backing()->suspendAnimations(time);
 }
 
@@ -983,7 +983,7 @@ bool RenderBoxModelObject::fixedBackgroundPaintsInLocalCoordinates() const
         return false;
 
     RenderLayer* rootLayer = view()->layer();
-    if (!rootLayer || !rootLayer->isComposited())
+    if (!rootLayer || rootLayer->compositingState() == NotComposited)

[Julien - ping for review, 2013/10/03 20:08:36]

Did you change your mind on this one as you said you would use backing()? Maybe
we can tighten the code (including ASSERTs & comments) based on Ian's review?

[shawnsingh, 2013/10/07 11:45:04]

I did address his comment, but the condition I chose is more appropriate.  You
can see my response to his comment... Please let me know if you think there is
still an issue here after seeing that.  =)

         return false;
 
     return rootLayer->backing()->backgroundLayerPaintsFixedRootBackground();