Store paint properties directly on LayoutObject

Store paint properties directly on LayoutObject

This patch removes the temporary map that was used to avoid changing
the size of LayoutObject. This is in preparation for launching
property trees.

On profiles, the paint property map lookup is the hottest function
when running the paint-offset-change benchmark. On blink.perf, this
patch is a large improvement on all benchmarks[1]:
  color-changes.html: -3.78%
  large-table-background-change-with-invisible-collapsed-borders.html: -30.77%
  large-table-background-change-with-visible-collapsed-borders.html: 0%
  large-table-collapsed-border-change.html: -8.61%
  large-table-collapsed-border-change-with-backgrounds.html: -10.09%
  large-table-collapsed-border-change-with-text.html: -13.9%
  large-table-repaint.html: -14.28%
  paint-offset-changes.html: -5.05%
  transform-changes.html: -1.62%

[1] tools/perf/run_benchmark blink_perf.paint --browser=content-shell-release --pageset-repeat=3 --extra-browser-args=--enable-slimming-paint-v2

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/3a5ab90f66206a967a646707dbdacb92b57bccc5
Cr-Commit-Position: refs/heads/master@{#431643}

[pdr., 2016-11-10 23:55:07]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, xianzhanzhu@chromium.org

[pdr., 2016-11-10 23:55:23]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 23:55:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 00:09:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 00:09:48]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[chrishtr, 2016-11-11 00:37:20]

lgtm

[pdr., 2016-11-11 04:00:42]

Description was changed from

==========
Store paint properties directly on LayoutObject

This patch removes the temporary map that was used to avoid changing
the size of LayoutObject. This is in preparation for launching
property trees.
==========

to

==========
Store paint properties directly on LayoutObject

This patch removes the temporary map that was used to avoid changing
the size of LayoutObject. This is in preparation for launching
property trees.

On profiles, the paint property map lookup is the hottest function
when running the paint-offset-change benchmark. On blink.perf, this
patch is a large improvement on all benchmarks[1]:
  color-changes.html: -3.78% 
  large-table-background-change-with-invisible-collapsed-borders.html: -30.77%
  large-table-background-change-with-visible-collapsed-borders.html: 0%
  large-table-collapsed-border-change.html: -8.61%
  large-table-collapsed-border-change-with-backgrounds.html: -10.09%
  large-table-collapsed-border-change-with-text.html: -13.9%
  large-table-repaint.html: -14.28%
  paint-offset-changes.html: -5.05%
  transform-changes.html: -1.62%

[1] tools/perf/run_benchmark blink_perf.paint --browser=content-shell-release
--pageset-repeat=3 --extra-browser-args=--enable-slimming-paint-v2

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2016-11-11 07:12:46]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 07:13:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 10:50:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 10:50:09]

Dry run: This issue passed the CQ dry run.

[pdr., 2016-11-11 19:11:52]

The CQ bit was checked by pdr@chromium.org

[pdr., 2016-11-11 19:11:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2492073002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-11 19:12:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 19:20:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 19:20:41]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pdr., 2016-11-11 19:22:16]

The CQ bit was checked by pdr@chromium.org

[pdr., 2016-11-11 19:22:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2492073002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-11 19:22:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2016-11-11 19:30:40]

I gave Emil a heads-up about this change.

I will keep an eye on the perf bots. If anyone finds a perf regression due to
this, please ping me and/or roll this out.

[commit-bot: I haz the power, 2016-11-11 21:11:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-11 21:14:26]

Description was changed from

==========
Store paint properties directly on LayoutObject

This patch removes the temporary map that was used to avoid changing
the size of LayoutObject. This is in preparation for launching
property trees.

On profiles, the paint property map lookup is the hottest function
when running the paint-offset-change benchmark. On blink.perf, this
patch is a large improvement on all benchmarks[1]:
  color-changes.html: -3.78% 
  large-table-background-change-with-invisible-collapsed-borders.html: -30.77%
  large-table-background-change-with-visible-collapsed-borders.html: 0%
  large-table-collapsed-border-change.html: -8.61%
  large-table-collapsed-border-change-with-backgrounds.html: -10.09%
  large-table-collapsed-border-change-with-text.html: -13.9%
  large-table-repaint.html: -14.28%
  paint-offset-changes.html: -5.05%
  transform-changes.html: -1.62%

[1] tools/perf/run_benchmark blink_perf.paint --browser=content-shell-release
--pageset-repeat=3 --extra-browser-args=--enable-slimming-paint-v2

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Store paint properties directly on LayoutObject

This patch removes the temporary map that was used to avoid changing
the size of LayoutObject. This is in preparation for launching
property trees.

On profiles, the paint property map lookup is the hottest function
when running the paint-offset-change benchmark. On blink.perf, this
patch is a large improvement on all benchmarks[1]:
  color-changes.html: -3.78%
  large-table-background-change-with-invisible-collapsed-borders.html: -30.77%
  large-table-background-change-with-visible-collapsed-borders.html: 0%
  large-table-collapsed-border-change.html: -8.61%
  large-table-collapsed-border-change-with-backgrounds.html: -10.09%
  large-table-collapsed-border-change-with-text.html: -13.9%
  large-table-repaint.html: -14.28%
  paint-offset-changes.html: -5.05%
  transform-changes.html: -1.62%

[1] tools/perf/run_benchmark blink_perf.paint --browser=content-shell-release
--pageset-repeat=3 --extra-browser-args=--enable-slimming-paint-v2

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/3a5ab90f66206a967a646707dbdacb92b57bccc5
Cr-Commit-Position: refs/heads/master@{#431643}
==========

[commit-bot: I haz the power, 2016-11-11 21:14:27]

Patchset 3 (id:??) landed as
https://crrev.com/3a5ab90f66206a967a646707dbdacb92b57bccc5
Cr-Commit-Position: refs/heads/master@{#431643}