Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2492053003: Fix 'impl/memory' context key. (Closed)

Created:
4 years, 1 month ago by dnj
Modified:
4 years, 1 month ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Fix 'impl/memory' context key. Currently the Context is using "1" as the key for the current transaction. Make it (a) something internal, and (b) a string pointer for easier Context readability. BUG=None TEST=None R=iannucci@chromium.org Committed: https://github.com/luci/gae/commit/da301ac8ccee61d3d59e0c548b890f7dd8adfa10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M impl/memory/context.go View 4 chunks +7 lines, -9 lines 0 comments Download
M impl/memory/datastore.go View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
dnj
4 years, 1 month ago (2016-11-11 20:34:21 UTC) #1
iannucci
lgtm
4 years, 1 month ago (2016-11-11 20:38:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492053003/1
4 years, 1 month ago (2016-11-11 20:38:26 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Luci-GAE Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/326df45b8a617710)
4 years, 1 month ago (2016-11-11 20:47:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492053003/1
4 years, 1 month ago (2016-11-11 20:49:46 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 20:53:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/da301ac8ccee61d3d59e0c548b890f7dd8adfa10

Powered by Google App Engine
This is Rietveld 408576698