Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2492053002: Revert "[gn] Consolidate exec_script calls to speed up generation" (Closed)

Created:
4 years, 1 month ago by jamesr
Modified:
4 years, 1 month ago
Reviewers:
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "[gn] Consolidate exec_script calls to speed up generation" Appears to break builds with errors like: ninja -C xcodebuild/ProductX64 runtime ninja: Entering directory `xcodebuild/ProductX64' ninja: error: '../../runtime/vm/async_patch.dart', needed by 'obj/runtime/vm/concatenate_async_patch.inputdeps.stamp', missing and no known rule to make it BUILD FAILED step returned non-zero exit code: 1 @@@STEP_FAILURE@@@ This reverts commit ad86d6ed26e3b6eeeaa96b654881a49c4b04a561. BUG= Committed: https://github.com/dart-lang/sdk/commit/e18404fd3b7fc907600fce68e6cbbf0ed7415947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -310 lines) Patch
M runtime/bin/BUILD.gn View 10 chunks +53 lines, -10 lines 0 comments Download
D runtime/bin/gypi_contents.gni View 1 chunk +0 lines, -43 lines 0 comments Download
M runtime/vm/BUILD.gn View 18 chunks +107 lines, -94 lines 0 comments Download
D runtime/vm/gypi_contents.gni View 1 chunk +0 lines, -54 lines 0 comments Download
M tools/gypi_to_gn.py View 6 chunks +58 lines, -40 lines 0 comments Download
D tools/process_gypis.py View 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jamesr
4 years, 1 month ago (2016-11-10 23:17:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e18404fd3b7fc907600fce68e6cbbf0ed7415947 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698