Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2492013004: Neuter font size scaling (Closed)

Created:
4 years, 1 month ago by fs
Modified:
4 years ago
Reviewers:
pdr.
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Neuter the "screen scale factor" computation for SVG <text> This removes the PaintLayer-factor and DSF from the "screen scale factor", leaving only the transform to the <svg> root and the "content transform" (used by <pattern>, <mask> and <clipPath>.) BUG=664961 Committed: https://crrev.com/6f80957a6a5e7ec792a2f3cd7f06e2a744196d1d Cr-Commit-Position: refs/heads/master@{#435599}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Update expectations #

Patch Set 4 : Rebase #

Patch Set 5 : Updated test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -46 lines) Patch
M third_party/WebKit/LayoutTests/platform/mac/svg/custom/masking-clipping-hidpi-expected.txt View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 2 chunks +5 lines, -39 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
fs
4 years ago (2016-11-29 17:03:52 UTC) #16
pdr.
On 2016/11/29 at 17:03:52, fs wrote: > Nice! LGTM
4 years ago (2016-11-30 07:44:12 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492013004/80001
4 years ago (2016-12-01 11:36:46 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-01 13:28:00 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-01 13:30:33 UTC) #23
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6f80957a6a5e7ec792a2f3cd7f06e2a744196d1d
Cr-Commit-Position: refs/heads/master@{#435599}

Powered by Google App Engine
This is Rietveld 408576698