Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 24920003: Function::Call and Object::CallAsFunction APIs should allow v8::Value as a receiver (Closed)

Created:
7 years, 2 months ago by yusukesuzuki
Modified:
7 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Function::Call and Object::CallAsFunction APIs should allow v8::Value as a receiver Since the primitive values can be a receiver of strict mode functions in ECMA262 5.1th, v8::Function::Call and Object::CallAsFunction should take v8::Value as a receiver instead of v8::Object. BUG=v8:2915 TEST=cctest/test-api R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17003

Patch Set 1 #

Patch Set 2 : Add CallAsFunction #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -7 lines) Patch
M include/v8.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/api.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 5 chunks +117 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yusukesuzuki
7 years, 2 months ago (2013-09-27 02:55:48 UTC) #1
Michael Starzinger
The same applies to Object::CallAsFunction, I think we should fix it in one CL to ...
7 years, 2 months ago (2013-09-27 12:38:42 UTC) #2
yusukesuzuki
On 2013/09/27 12:38:42, Michael Starzinger wrote: > The same applies to Object::CallAsFunction, I think we ...
7 years, 2 months ago (2013-09-27 13:44:17 UTC) #3
Michael Starzinger
LGTM. I'll land this once the nits in the test-case are addressed. https://codereview.chromium.org/24920003/diff/5001/test/cctest/test-api.cc File test/cctest/test-api.cc ...
7 years, 2 months ago (2013-09-30 11:17:41 UTC) #4
yusukesuzuki
https://chromiumcodereview.appspot.com/24920003/diff/5001/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://chromiumcodereview.appspot.com/24920003/diff/5001/test/cctest/test-api.cc#newcode10342 test/cctest/test-api.cc:10342: Local<v8::Value> a1 = instance->CallAsFunction(v8::Undefined(isolate), 0, NULL); On 2013/09/30 11:17:41, ...
7 years, 2 months ago (2013-09-30 11:32:19 UTC) #5
Michael Starzinger
7 years, 2 months ago (2013-09-30 11:47:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r17003 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698