ui/gl: Initialize the ANGLE Platform on all configurations

ui/gl/init/gl_initializer_android.cc

Index: ui/gl/init/gl_initializer_android.cc
diff --git a/ui/gl/init/gl_initializer_android.cc b/ui/gl/init/gl_initializer_android.cc
index a6a1bc4c022a202c7a9575f23feedf62f4862815..72328d007b35b0e661efaa419731d4ea29b7193b 100644
--- a/ui/gl/init/gl_initializer_android.cc
+++ b/ui/gl/init/gl_initializer_android.cc
@@ -97,6 +97,7 @@ void InitializeDebugGLBindings() {
 }
 
 void ClearGLBindingsPlatform() {
+  GLSurfaceEGL::ShutdownOneOff();

[Ken Russell (switch to Gerrit), 2016/11/14 20:02:24]

It seems asymmetric that a GLSurface ShutdownOneOff would be done in
ClearGLBindingsPlatform, when InitializeOneOff is called inside
InitializeGLOneOffPlatform -- especially given that this calls eglTerminate.

Is it worth adding a new entry point to do this work and modifying all the call
sites?

Is this code correct on all platforms which use EGL, or has it only been tested
with ANGLE? (Does ClearGLBindingsEGL do any EGL-related work?)

[Corentin Wallez, 2016/11/30 16:07:08]

Thanks for pointing this out. Looking at the code, ResetForTesting is used in
OzoneEGL::ClearGLBindings and platform ClearGLBindings is used in tests and the
vr_shell. Also at initialization the gl bindings is initialized, then the
platform one off initialization is done, ClearGLBindings is currently clearing
the gl bindings but the way it is used is to deinit the GL completely.

How about renaming ClearGLBindings to ShutdownGL and keep the approach here?

   ClearGLBindingsEGL();
   ClearGLBindingsGL();
   ClearGLBindingsOSMESA();