Changes for https://github.com/dart-lang/sdk/issues/27742 mark tear-offs using the id#x syntax as d…

Changes for https://github.com/dart-lang/sdk/issues/27742 mark tear-offs using the x#id syntax as deprecated.

BUG=#27742
R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/e25cdc78e4a5698e7b1c465b1b4d59e880ad299b

[siva, 2016-11-11 17:59:13]

Description was changed from

==========
Changes for https://github.com/dart-lang/sdk/issues/27742 mark tear-offs using
the id#x syntax as deprecated.

BUG=#27742
==========

to

==========
Changes for https://github.com/dart-lang/sdk/issues/27742 mark tear-offs using
the x#id syntax as deprecated.

BUG=#27742
==========

[siva, 2016-11-11 17:59:24]

asiva@google.com changed reviewers:
+ hausner@google.com

[hausner, 2016-11-11 18:10:38]

LGTM w/comment.

https://codereview.chromium.org/2491983003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2491983003/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:11670: if (FLAG_warn_new_tearoff_syntax) {
Nit: I'd move the warning to before the ExpectTpken() call so the warning is
reported at the # operator.

https://codereview.chromium.org/2491983003/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:13260: if (FLAG_warn_new_tearoff_syntax) {
Nit: I'd move the check to before the ExpectToken() call so the warning gets
reported at the location of the # operator.

https://codereview.chromium.org/2491983003/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:13808: // Closurization of top-level entity in prefix
scope.
Need a warning here, I think.

[siva, 2016-11-11 18:58:01]

https://codereview.chromium.org/2491983003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2491983003/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:11670: if (FLAG_warn_new_tearoff_syntax) {
On 2016/11/11 18:10:38, hausner wrote:
> Nit: I'd move the warning to before the ExpectTpken() call so the warning is
> reported at the # operator.

Done.

https://codereview.chromium.org/2491983003/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:13260: if (FLAG_warn_new_tearoff_syntax) {
On 2016/11/11 18:10:38, hausner wrote:
> Nit: I'd move the check to before the ExpectToken() call so the warning gets
> reported at the location of the # operator.

Done.

https://codereview.chromium.org/2491983003/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:13808: // Closurization of top-level entity in prefix
scope.
On 2016/11/11 18:10:38, hausner wrote:
> Need a warning here, I think.

Done.

[siva, 2016-11-11 20:09:05]

Description was changed from

==========
Changes for https://github.com/dart-lang/sdk/issues/27742 mark tear-offs using
the x#id syntax as deprecated.

BUG=#27742
==========

to

==========
Changes for https://github.com/dart-lang/sdk/issues/27742 mark tear-offs using
the x#id syntax as deprecated.

BUG=#27742
R=hausner@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e25cdc78e4a5698e7b1c465b1b4d59e880ad299b
==========

[siva, 2016-11-11 20:09:06]

Committed patchset #2 (id:20001) manually as
e25cdc78e4a5698e7b1c465b1b4d59e880ad299b (presubmit successful).