third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-formatter-breakpoints-3.html - Issue 2491983002: [DevTools] reworked JavaScriptBreakpointsSidebarPane.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-formatter-breakpoints-3.html

Issue 2491983002: [DevTools] reworked JavaScriptBreakpointsSidebarPane.js (Closed)

Patch Set: addressed offline comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-formatter-breakpoints-2.html ('k') | third_party/WebKit/Source/devtools/front_end/components/breakpointsList.css » ('j') | third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../../http/tests/inspector/inspector-test.js"></script>	3 <script src="../../../http/tests/inspector/inspector-test.js"></script>

4 <script src="../../../http/tests/inspector/debugger-test.js"></script>	4 <script src="../../../http/tests/inspector/debugger-test.js"></script>

5 <script src="../debugger/resources/unformatted3.js"></script>	5 <script src="../debugger/resources/unformatted3.js"></script>

6 <script>	6 <script>

7 var test = function()	7 var test = function()

8 {	8 {

9 WebInspector.breakpointManager._storage._breakpoints = {};	9 WebInspector.breakpointManager._storage._breakpoints = {};

10 var panel = WebInspector.panels.sources;	10 var panel = WebInspector.panels.sources;

(...skipping 23 matching lines...) Expand all Loading...
34 var formattedSourceFrame = panel.visibleView;	34 var formattedSourceFrame = panel.visibleView;

35 InspectorTest.setBreakpoint(formattedSourceFrame, 3, "", true);	35 InspectorTest.setBreakpoint(formattedSourceFrame, 3, "", true);

36 InspectorTest.waitUntilPaused(pausedInF2);	36 InspectorTest.waitUntilPaused(pausedInF2);

37 InspectorTest.evaluateInPageWithTimeout("f2()");	37 InspectorTest.evaluateInPageWithTimeout("f2()");

38 }	38 }

39	39

40 function pausedInF2(callFrames)	40 function pausedInF2(callFrames)

41 {	41 {

42 InspectorTest.dumpBreakpointSidebarPane("while paused in pretty printed");	42 InspectorTest.dumpBreakpointSidebarPane("while paused in pretty printed");

43 scriptFormatter._discardFormattedUISourceCodeScript(panel.visibl eView.uiSourceCode());	43 scriptFormatter._discardFormattedUISourceCodeScript(panel.visibl eView.uiSourceCode());

	44 InspectorTest.addSniffer(WebInspector.JavaScriptBreakpointsSideb arPane.prototype, "didUpdateForTest", dumpBreakpointsSidebarPane.bind(this));

	45 }

	46

	47 function dumpBreakpointsSidebarPane()

	48 {

44 InspectorTest.dumpBreakpointSidebarPane("while paused in raw");	49 InspectorTest.dumpBreakpointSidebarPane("while paused in raw");

45 // No need to remove breakpoint since formattedUISourceCode was removed.	50 InspectorTest.resumeExecution(next);

46 InspectorTest.resumeExecution(next);

47 }	51 }

	52

48 }	53 }

49 ]);	54 ]);

50	55

51 }	56 }

52 </script>	57 </script>

53 </head>	58 </head>

54 <body onload="runTest()">	59 <body onload="runTest()">

55 <p>Tests the script formatting is working fine with breakpoints.	60 <p>Tests the script formatting is working fine with breakpoints.

56 </p>	61 </p>

57 </body>	62 </body>

58 </html>	63 </html>

OLD	NEW