Reland of Fix link's hover state if the link under scrollbar

Reland of Fix link's hover state if the link under scrollbar (patchset #1 id:1 of https://codereview.chromium.org/2485203002/ )

Reason for revert:
Relanding now that crrev.com/2467693002 has been relanded.

Original issue's description:
> Revert of Fix link's hover state if the link under scrollbar (patchset #10 id:180001 of https://codereview.chromium.org/2389073002/ )
>
> Reason for revert:
> Due to crbug.com/662402, need to revert crrev.com/2467693002 which this depends on. I'll reland when the dust settles.
>
> Original issue's description:
> > Fix link's hover state if the link under scrollbar
> >
> > In this patch, we check the hitTest includes scrollbar in
> > ChromeClientImpl::showMouseOverURL, ChromeClient::mouseDidMoveOverElement,
> > Document::updateHoverActiveState, EventHandler::selectAutoCursor to prevent
> > showing url, tooltip and hand cursor when mouse move on the link under scrollbar
> > or showing active state when mouse click on the link under scrollbar.
> >
> > BUG=636436
> >
> > Committed: https://crrev.com/524f6ac4628d3d5249d291314c6100bd0a337053
> > Cr-Commit-Position: refs/heads/master@{#430141}
>
> TBR=chaopeng@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=636436
>
> Committed: https://crrev.com/898ff2df4c04bee36bce24d6945511af39ee79e4
> Cr-Commit-Position: refs/heads/master@{#430717}

TBR=chaopeng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=636436
Committed: https://crrev.com/55444d25b3aec61cbcf053448b3bb999b4bf859b
Cr-Commit-Position: refs/heads/master@{#431702}

[bokan, 2016-11-11 19:03:35]

The CQ bit was checked by bokan@chromium.org

[bokan, 2016-11-11 19:03:35]

Created Reland of Fix link's hover state if the link under scrollbar

[commit-bot: I haz the power, 2016-11-11 19:04:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 20:46:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 20:46:23]

Failed to apply patch for third_party/WebKit/Source/web/tests/WebFrameTest.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/web/tests/WebFrameTest.cpp:10346
  error: third_party/WebKit/Source/web/tests/WebFrameTest.cpp: patch does not
apply

Patch:       third_party/WebKit/Source/web/tests/WebFrameTest.cpp
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index
676f6d6ac30b0f28c2dd8a3d4d7caf43757960a9..978cdebe62784199e06dde16365ff7c34492f3e9
100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -79,13 +79,18 @@
 #include "core/testing/NullExecutionContext.h"
 #include "modules/mediastream/MediaStream.h"
 #include "modules/mediastream/MediaStreamRegistry.h"
+#include "platform/Cursor.h"
 #include "platform/DragImage.h"
+#include "platform/PlatformMouseEvent.h"
 #include "platform/PlatformResourceLoader.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/UserGestureIndicator.h"
 #include "platform/geometry/FloatRect.h"
 #include "platform/network/ResourceError.h"
+#include "platform/scroll/Scrollbar.h"
+#include "platform/scroll/ScrollbarTestSuite.h"
 #include "platform/scroll/ScrollbarTheme.h"
+#include "platform/scroll/ScrollbarThemeMock.h"
 #include "platform/scroll/ScrollbarThemeOverlayMock.h"
 #include "platform/testing/RuntimeEnabledFeaturesTestHelpers.h"
 #include "platform/testing/URLTestHelpers.h"
@@ -10346,6 +10351,104 @@
   EXPECT_TRUE(scrollerArea->verticalScrollbar()->enabled());
 }
 
+// Makes sure that mouse hover over an overlay scrollbar doesn't activate
+// elements below unless the scrollbar is faded out.
+TEST_F(WebFrameTest, MouseOverLinkAndOverlayScrollbar) {
+  FrameTestHelpers::WebViewHelper webViewHelper;
+  webViewHelper.initialize(
+      true, nullptr, nullptr, nullptr,
+      [](WebSettings* settings) { settings->setDeviceSupportsMouse(true); });
+  webViewHelper.resize(WebSize(20, 20));
+  WebViewImpl* webView = webViewHelper.webView();
+
+  initializeWithHTML(*webView->mainFrameImpl()->frame(),
+                     "<!DOCTYPE html>"
+                     "<a id='a' href='javascript:void(0);'>"
+                    
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+                    
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+                    
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+                     "</a>"
+                     "<div style='position: absolute; top: 1000px'>end</div>");
+
+  webView->updateAllLifecyclePhases();
+
+  Document* document = webView->mainFrameImpl()->frame()->document();
+  Element* aTag = document->getElementById("a");
+
+  // Ensure hittest has scrollbar and link
+  HitTestResult hitTestResult =
+      webView->coreHitTestResultAt(WebPoint(18, aTag->offsetTop()));
+
+  EXPECT_TRUE(hitTestResult.URLElement());
+  EXPECT_TRUE(hitTestResult.innerElement());
+  EXPECT_TRUE(hitTestResult.scrollbar());
+
+  // Mouse over link. Mouse cursor should be hand.
+  PlatformMouseEvent mouseMoveOverLinkEvent(
+      IntPoint(aTag->offsetLeft(), aTag->offsetTop()),
+      IntPoint(aTag->offsetLeft(), aTag->offsetTop()),
+      WebPointerProperties::Button::NoButton, PlatformEvent::MouseMoved, 0,
+      PlatformEvent::NoModifiers, WTF::monotonicallyIncreasingTime());
+  document->frame()->eventHandler().handleMouseMoveEvent(
+      mouseMoveOverLinkEvent);
+
+  EXPECT_EQ(
+      Cursor::Type::Hand,
+      document->frame()->chromeClient().lastSetCursorForTesting().getType());
+
+  // Mouse over enabled overlay scrollbar. Mouse cursor should be pointer and
no
+  // active hover element.
+  PlatformMouseEvent mouseMoveEvent(
+      IntPoint(18, aTag->offsetTop()), IntPoint(18, aTag->offsetTop()),
+      WebPointerProperties::Button::NoButton, PlatformEvent::MouseMoved, 0,
+      PlatformEvent::NoModifiers, WTF::monotonicallyIncreasingTime());
+  document->frame()->eventHandler().handleMouseMoveEvent(mouseMoveEvent);
+
+  EXPECT_EQ(
+      Cursor::Type::Pointer,
+      document->frame()->chromeClient().lastSetCursorForTesting().getType());
+
+  PlatformMouseEvent mousePressEvent(
+      IntPoint(18, aTag->offsetTop()), IntPoint(18, aTag->offsetTop()),
+      WebPointerProperties::Button::Left, PlatformEvent::MousePressed, 0,
+      PlatformEvent::Modifiers::LeftButtonDown,
+      WTF::monotonicallyIncreasingTime());
+  document->frame()->eventHandler().handleMousePressEvent(mousePressEvent);
+
+  EXPECT_FALSE(document->activeHoverElement());
+  EXPECT_FALSE(document->hoverNode());
+
+  PlatformMouseEvent MouseReleaseEvent(
+      IntPoint(18, aTag->offsetTop()), IntPoint(18, aTag->offsetTop()),
+      WebPointerProperties::Button::Left, PlatformEvent::MouseReleased, 0,
+      PlatformEvent::Modifiers::LeftButtonDown,
+      WTF::monotonicallyIncreasingTime());
+  document->frame()->eventHandler().handleMouseReleaseEvent(MouseReleaseEvent);
+
+  // Mouse over disabled overlay scrollbar. Mouse cursor should be hand and has
+  // active hover element.
+  webView->mainFrameImpl()->frameView()->setScrollbarsHidden(true);
+
+  // Ensure hittest only has link
+  hitTestResult = webView->coreHitTestResultAt(WebPoint(18,
aTag->offsetTop()));
+
+  EXPECT_TRUE(hitTestResult.URLElement());
+  EXPECT_TRUE(hitTestResult.innerElement());
+  EXPECT_FALSE(hitTestResult.scrollbar());
+
+  document->frame()->eventHandler().handleMouseMoveEvent(mouseMoveEvent);
+
+  EXPECT_EQ(
+      Cursor::Type::Hand,
+      document->frame()->chromeClient().lastSetCursorForTesting().getType());
+
+  document->frame()->eventHandler().handleMousePressEvent(mousePressEvent);
+
+  EXPECT_TRUE(document->activeHoverElement());
+  EXPECT_TRUE(document->hoverNode());
+
+  document->frame()->eventHandler().handleMouseReleaseEvent(MouseReleaseEvent);
+}
 static void disableCompositing(WebSettings* settings) {
   settings->setAcceleratedCompositingEnabled(false);
   settings->setPreferCompositingToLCDTextEnabled(false);

[bokan, 2016-11-11 20:54:27]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2016-11-11 20:55:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 20:59:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 20:59:41]

Failed to apply patch for third_party/WebKit/Source/web/tests/WebFrameTest.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/web/tests/WebFrameTest.cpp:10346
  error: third_party/WebKit/Source/web/tests/WebFrameTest.cpp: patch does not
apply

Patch:       third_party/WebKit/Source/web/tests/WebFrameTest.cpp
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index
676f6d6ac30b0f28c2dd8a3d4d7caf43757960a9..978cdebe62784199e06dde16365ff7c34492f3e9
100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -79,13 +79,18 @@
 #include "core/testing/NullExecutionContext.h"
 #include "modules/mediastream/MediaStream.h"
 #include "modules/mediastream/MediaStreamRegistry.h"
+#include "platform/Cursor.h"
 #include "platform/DragImage.h"
+#include "platform/PlatformMouseEvent.h"
 #include "platform/PlatformResourceLoader.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/UserGestureIndicator.h"
 #include "platform/geometry/FloatRect.h"
 #include "platform/network/ResourceError.h"
+#include "platform/scroll/Scrollbar.h"
+#include "platform/scroll/ScrollbarTestSuite.h"
 #include "platform/scroll/ScrollbarTheme.h"
+#include "platform/scroll/ScrollbarThemeMock.h"
 #include "platform/scroll/ScrollbarThemeOverlayMock.h"
 #include "platform/testing/RuntimeEnabledFeaturesTestHelpers.h"
 #include "platform/testing/URLTestHelpers.h"
@@ -10346,6 +10351,104 @@
   EXPECT_TRUE(scrollerArea->verticalScrollbar()->enabled());
 }
 
+// Makes sure that mouse hover over an overlay scrollbar doesn't activate
+// elements below unless the scrollbar is faded out.
+TEST_F(WebFrameTest, MouseOverLinkAndOverlayScrollbar) {
+  FrameTestHelpers::WebViewHelper webViewHelper;
+  webViewHelper.initialize(
+      true, nullptr, nullptr, nullptr,
+      [](WebSettings* settings) { settings->setDeviceSupportsMouse(true); });
+  webViewHelper.resize(WebSize(20, 20));
+  WebViewImpl* webView = webViewHelper.webView();
+
+  initializeWithHTML(*webView->mainFrameImpl()->frame(),
+                     "<!DOCTYPE html>"
+                     "<a id='a' href='javascript:void(0);'>"
+                    
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+                    
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+                    
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+                     "</a>"
+                     "<div style='position: absolute; top: 1000px'>end</div>");
+
+  webView->updateAllLifecyclePhases();
+
+  Document* document = webView->mainFrameImpl()->frame()->document();
+  Element* aTag = document->getElementById("a");
+
+  // Ensure hittest has scrollbar and link
+  HitTestResult hitTestResult =
+      webView->coreHitTestResultAt(WebPoint(18, aTag->offsetTop()));
+
+  EXPECT_TRUE(hitTestResult.URLElement());
+  EXPECT_TRUE(hitTestResult.innerElement());
+  EXPECT_TRUE(hitTestResult.scrollbar());
+
+  // Mouse over link. Mouse cursor should be hand.
+  PlatformMouseEvent mouseMoveOverLinkEvent(
+      IntPoint(aTag->offsetLeft(), aTag->offsetTop()),
+      IntPoint(aTag->offsetLeft(), aTag->offsetTop()),
+      WebPointerProperties::Button::NoButton, PlatformEvent::MouseMoved, 0,
+      PlatformEvent::NoModifiers, WTF::monotonicallyIncreasingTime());
+  document->frame()->eventHandler().handleMouseMoveEvent(
+      mouseMoveOverLinkEvent);
+
+  EXPECT_EQ(
+      Cursor::Type::Hand,
+      document->frame()->chromeClient().lastSetCursorForTesting().getType());
+
+  // Mouse over enabled overlay scrollbar. Mouse cursor should be pointer and
no
+  // active hover element.
+  PlatformMouseEvent mouseMoveEvent(
+      IntPoint(18, aTag->offsetTop()), IntPoint(18, aTag->offsetTop()),
+      WebPointerProperties::Button::NoButton, PlatformEvent::MouseMoved, 0,
+      PlatformEvent::NoModifiers, WTF::monotonicallyIncreasingTime());
+  document->frame()->eventHandler().handleMouseMoveEvent(mouseMoveEvent);
+
+  EXPECT_EQ(
+      Cursor::Type::Pointer,
+      document->frame()->chromeClient().lastSetCursorForTesting().getType());
+
+  PlatformMouseEvent mousePressEvent(
+      IntPoint(18, aTag->offsetTop()), IntPoint(18, aTag->offsetTop()),
+      WebPointerProperties::Button::Left, PlatformEvent::MousePressed, 0,
+      PlatformEvent::Modifiers::LeftButtonDown,
+      WTF::monotonicallyIncreasingTime());
+  document->frame()->eventHandler().handleMousePressEvent(mousePressEvent);
+
+  EXPECT_FALSE(document->activeHoverElement());
+  EXPECT_FALSE(document->hoverNode());
+
+  PlatformMouseEvent MouseReleaseEvent(
+      IntPoint(18, aTag->offsetTop()), IntPoint(18, aTag->offsetTop()),
+      WebPointerProperties::Button::Left, PlatformEvent::MouseReleased, 0,
+      PlatformEvent::Modifiers::LeftButtonDown,
+      WTF::monotonicallyIncreasingTime());
+  document->frame()->eventHandler().handleMouseReleaseEvent(MouseReleaseEvent);
+
+  // Mouse over disabled overlay scrollbar. Mouse cursor should be hand and has
+  // active hover element.
+  webView->mainFrameImpl()->frameView()->setScrollbarsHidden(true);
+
+  // Ensure hittest only has link
+  hitTestResult = webView->coreHitTestResultAt(WebPoint(18,
aTag->offsetTop()));
+
+  EXPECT_TRUE(hitTestResult.URLElement());
+  EXPECT_TRUE(hitTestResult.innerElement());
+  EXPECT_FALSE(hitTestResult.scrollbar());
+
+  document->frame()->eventHandler().handleMouseMoveEvent(mouseMoveEvent);
+
+  EXPECT_EQ(
+      Cursor::Type::Hand,
+      document->frame()->chromeClient().lastSetCursorForTesting().getType());
+
+  document->frame()->eventHandler().handleMousePressEvent(mousePressEvent);
+
+  EXPECT_TRUE(document->activeHoverElement());
+  EXPECT_TRUE(document->hoverNode());
+
+  document->frame()->eventHandler().handleMouseReleaseEvent(MouseReleaseEvent);
+}
 static void disableCompositing(WebSettings* settings) {
   settings->setAcceleratedCompositingEnabled(false);
   settings->setPreferCompositingToLCDTextEnabled(false);

[bokan, 2016-11-11 21:22:00]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2016-11-11 21:22:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 00:28:10]

Committed patchset #2 (id:150001)

[commit-bot: I haz the power, 2016-11-12 00:30:10]

Description was changed from

==========
Reland of Fix link's hover state if the link under scrollbar (patchset #1 id:1
of https://codereview.chromium.org/2485203002/ )

Reason for revert:
Relanding now that crrev.com/2467693002 has been relanded.

Original issue's description:
> Revert of Fix link's hover state if the link under scrollbar (patchset #10
id:180001 of https://codereview.chromium.org/2389073002/ )
> 
> Reason for revert:
> Due to crbug.com/662402, need to revert crrev.com/2467693002 which this
depends on. I'll reland when the dust settles.
> 
> Original issue's description:
> > Fix link's hover state if the link under scrollbar
> >
> > In this patch, we check the hitTest includes scrollbar in
> > ChromeClientImpl::showMouseOverURL, ChromeClient::mouseDidMoveOverElement,
> > Document::updateHoverActiveState, EventHandler::selectAutoCursor to prevent
> > showing url, tooltip and hand cursor when mouse move on the link under
scrollbar
> > or showing active state when mouse click on the link under scrollbar.
> >
> > BUG=636436
> >
> > Committed: https://crrev.com/524f6ac4628d3d5249d291314c6100bd0a337053
> > Cr-Commit-Position: refs/heads/master@{#430141}
> 
> TBR=chaopeng@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=636436
> 
> Committed: https://crrev.com/898ff2df4c04bee36bce24d6945511af39ee79e4
> Cr-Commit-Position: refs/heads/master@{#430717}

TBR=chaopeng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=636436
==========

to

==========
Reland of Fix link's hover state if the link under scrollbar (patchset #1 id:1
of https://codereview.chromium.org/2485203002/ )

Reason for revert:
Relanding now that crrev.com/2467693002 has been relanded.

Original issue's description:
> Revert of Fix link's hover state if the link under scrollbar (patchset #10
id:180001 of https://codereview.chromium.org/2389073002/ )
>
> Reason for revert:
> Due to crbug.com/662402, need to revert crrev.com/2467693002 which this
depends on. I'll reland when the dust settles.
>
> Original issue's description:
> > Fix link's hover state if the link under scrollbar
> >
> > In this patch, we check the hitTest includes scrollbar in
> > ChromeClientImpl::showMouseOverURL, ChromeClient::mouseDidMoveOverElement,
> > Document::updateHoverActiveState, EventHandler::selectAutoCursor to prevent
> > showing url, tooltip and hand cursor when mouse move on the link under
scrollbar
> > or showing active state when mouse click on the link under scrollbar.
> >
> > BUG=636436
> >
> > Committed: https://crrev.com/524f6ac4628d3d5249d291314c6100bd0a337053
> > Cr-Commit-Position: refs/heads/master@{#430141}
>
> TBR=chaopeng@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=636436
>
> Committed: https://crrev.com/898ff2df4c04bee36bce24d6945511af39ee79e4
> Cr-Commit-Position: refs/heads/master@{#430717}

TBR=chaopeng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=636436

Committed: https://crrev.com/55444d25b3aec61cbcf053448b3bb999b4bf859b
Cr-Commit-Position: refs/heads/master@{#431702}
==========

[commit-bot: I haz the power, 2016-11-12 00:30:11]

Patchset 2 (id:??) landed as
https://crrev.com/55444d25b3aec61cbcf053448b3bb999b4bf859b
Cr-Commit-Position: refs/heads/master@{#431702}