Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2491943002: Destroy GamepadDataFetchers on the polling thread. (Closed)

Created:
4 years, 1 month ago by fdoray
Modified:
4 years, 1 month ago
Reviewers:
bajones
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Destroy GamepadDataFetchers on the polling thread. GamepadPlatformDataFetcherLinux encapsulates a FileDescriptorWatcher::Controller whose destructor needs to be called on the same sequence as its constructor. This decision was discussed in the design doc for FileDescriptorWatcher https://docs.google.com/document/d/1F5CjON2JNtCtdEug3LOL8-avj188k_xOgqzdv288Q_s/edit?usp=sharing BUG=663950 Committed: https://crrev.com/f982e5aa10e88c9b0656ec751d47205d873069c2 Cr-Commit-Position: refs/heads/master@{#431372}

Patch Set 1 #

Patch Set 2 : self-review #

Patch Set 3 : fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M device/gamepad/gamepad_provider.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
fdoray
PTAL
4 years, 1 month ago (2016-11-10 16:53:08 UTC) #4
bajones
On 2016/11/10 16:53:08, fdoray wrote: > PTAL Logic LGTM once you fix the compile issue.
4 years, 1 month ago (2016-11-10 20:44:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491943002/40001
4 years, 1 month ago (2016-11-10 21:10:13 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-10 21:56:58 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 23:10:04 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f982e5aa10e88c9b0656ec751d47205d873069c2
Cr-Commit-Position: refs/heads/master@{#431372}

Powered by Google App Engine
This is Rietveld 408576698