chromeos/test/data/network/shill_ethernet.json - Issue 249193003: Add Shill to ONC translation of IPConfig.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromeos/test/data/network/shill_ethernet.json

Issue 249193003: Add Shill to ONC translation of IPConfig. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 { "GUID": "guid",	1 {

2 "Type": "ethernet",	2 "GUID":"guid",

	3 "IPConfig":{

	4 "Address":"123.123.123.123",
	armansito 2014/04/23 18:46:36 You should add a test case for an IPConfig with an You should add a test case for an IPConfig with an IPv6 address as well. pneubeck (no reviews) 2014/04/25 10:07:34 Done. Show quoted text On 2014/04/23 18:46:36, armansito wrote: > You should add a test case for an IPConfig with an IPv6 address as well. Done.
	5 "Gateway":"1.1.1.1",

	6 "NameServers":[

	7 "1.1.1.2",

	8 "1.1.1.3"

	9 ],

	10 "Prefixlen":24

	11 },

	12 "Type":"ethernet"

3 }	13 }

OLD	NEW