Add Shill to ONC translation of IPConfig.

chromeos/network/onc/onc_signature.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/onc/onc_signature.h"
 
 #include "components/onc/onc_constants.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
 using base::Value;
@@ skipping 145 matching lines @@
     { ::onc::vpn::kOpenVPN, &kOpenVPNSignature},
     { ::onc::vpn::kType, &kStringSignature},
     {NULL}};
 
 const OncFieldSignature ethernet_fields[] = {
     { ::onc::kRecommended, &kRecommendedSignature},
     { ::onc::ethernet::kAuthentication, &kStringSignature},
     { ::onc::ethernet::kEAP, &kEAPSignature},
     {NULL}};
 
-// Not supported, yet.
+// Not supported for policy but for reading network state.

[armansito, 2014/04/23 18:46:36]

So these will be reported by network state but is unused for policy? Just wanted
to clarify.

[pneubeck (no reviews), 2014/04/25 10:07:34]

Yes.
- They are accepted during validation of any ONC (in particular policy). That
is, because at some time I completed the signature to what the onc_spec.html
says.

- These are never written to Shill (no matter what source).

- As policy they are just ignored and never applied (e.g. never merged with user
settings).

 const OncFieldSignature ipconfig_fields[] = {
     { ::onc::ipconfig::kGateway, &kStringSignature},
     { ::onc::ipconfig::kIPAddress, &kStringSignature},
-    { ::onc::network_config::kNameServers, &kStringSignature},
+    { ::onc::ipconfig::kNameServers, &kStringListSignature},
     { ::onc::ipconfig::kRoutingPrefix, &kIntegerSignature},
     { ::onc::network_config::kSearchDomains, &kStringListSignature},
     { ::onc::ipconfig::kType, &kStringSignature},
     {NULL}};
 
 const OncFieldSignature proxy_location_fields[] = {
     { ::onc::proxy::kHost, &kStringSignature},
     { ::onc::proxy::kPort, &kIntegerSignature}, {NULL}};
 
 const OncFieldSignature proxy_manual_fields[] = {
@@ skipping 73 matching lines @@
     { ::onc::cellular::kSIMLockStatus, &kStringSignature},
     { ::onc::cellular::kSIMPresent, &kStringSignature},
     { ::onc::cellular::kSupportedCarriers, &kStringSignature},
     { ::onc::cellular::kSupportNetworkScan, &kStringSignature},
     {NULL}};
 
 const OncFieldSignature network_configuration_fields[] = {
     { ::onc::kRecommended, &kRecommendedSignature},
     { ::onc::network_config::kEthernet, &kEthernetSignature},
     { ::onc::network_config::kGUID, &kStringSignature},
-    // Not supported, yet.
+    // Not supported for policy but for reading network state.
     { ::onc::network_config::kIPConfigs, &kIPConfigListSignature},
     { ::onc::network_config::kName, &kStringSignature},
     // Not supported, yet.
     { ::onc::network_config::kNameServers, &kStringListSignature},
     { ::onc::network_config::kProxySettings, &kProxySettingsSignature},
     { ::onc::kRemove, &kBoolSignature},
     // Not supported, yet.
     { ::onc::network_config::kSearchDomains, &kStringListSignature},
     { ::onc::network_config::kType, &kStringSignature},
     { ::onc::network_config::kVPN, &kVPNSignature},
@@ skipping 169 matching lines @@
     if (&signature == entry->value_signature &&
         onc_field_name == entry->field_name) {
       return true;
     }
   }
   return false;
 }
 
 }  // namespace onc
 }  // namespace chromeos