Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 24919002: Update Linux ninja binaries to not require GLIBC_2.14. (Closed)

Created:
7 years, 2 months ago by Lei Zhang
Modified:
7 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, mstensho (USE GERRIT)
Visibility:
Public.

Description

Update Linux ninja binaries to not require GLIBC_2.14. BUG=298725 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225756

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M ninja-linux32 View Binary file 0 comments Download
M ninja-linux64 View Binary file 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
These are built with --sysroot=src/chrome/installer/linux/debian_wheezy_{i386,amd64}-sysroot
7 years, 2 months ago (2013-09-27 00:55:17 UTC) #1
Nico
Lgtm with added bug= link. I assume you ran ninja_tests and checked the output of ...
7 years, 2 months ago (2013-09-27 01:23:40 UTC) #2
Lei Zhang
On 2013/09/27 01:23:40, Nico wrote: > Lgtm with added bug= link. I assume you ran ...
7 years, 2 months ago (2013-09-27 01:25:08 UTC) #3
Lei Zhang
7 years, 2 months ago (2013-09-27 19:21:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r225756.

Powered by Google App Engine
This is Rietveld 408576698