Implement open_resource in non-SFI mode.

ppapi/nacl_irt/manifest_service.cc

Index: ppapi/nacl_irt/manifest_service.cc
diff --git a/ppapi/nacl_irt/manifest_service.cc b/ppapi/nacl_irt/manifest_service.cc
index ed7c4ebf969ffe9d337780ad426831abfcb3f4a0..379fcd8a15580f320ca14f7d9357b99a9851b7c0 100644
--- a/ppapi/nacl_irt/manifest_service.cc
+++ b/ppapi/nacl_irt/manifest_service.cc
@@ -12,6 +12,8 @@
 
 namespace ppapi {
 
+const char kFilePrefix[] = "files/";
+
 ManifestService::ManifestService(
     const IPC::ChannelHandle& handle,
     scoped_refptr<base::MessageLoopProxy> io_message_loop,
@@ -19,7 +21,7 @@ ManifestService::ManifestService(
   filter_ = new IPC::SyncMessageFilter(shutdown_event);
   channel_.reset(new IPC::ChannelProxy(handle,
                                        IPC::Channel::MODE_SERVER,
-                                       NULL, // Listener
+                                       NULL,  // Listener
                                        io_message_loop));
   channel_->AddFilter(filter_.get());
 }
@@ -31,4 +33,17 @@ void ManifestService::StartupInitializationComplete() {
   filter_->Send(new PpapiHostMsg_StartupInitializationComplete);
 }
 
+bool ManifestService::OpenResource(const char* file, int* fd) {
+  ppapi::proxy::SerializedHandle ipc_fd;
+  if (!filter_->Send(new PpapiHostMsg_OpenResource(
+          std::string(kFilePrefix) + file, &ipc_fd))) {

[dmichael (off chromium), 2014/04/25 21:06:58]

Why this magical files/ prefix? Shouldn't "file" just be a relative URL?

[Mark Seaborn, 2014/04/26 00:18:59]

This is matching existing behaviour, I guess (which is not well-documented). 
Note that this is not a URL.

[hidehiko, 2014/04/28 08:44:27]

Exactly as Mark said, this is just to be compatible with the current NaCl (i.e.
NaCl in SFI-mode).
IMHO, eventually we can clean this up, but at least I'd like to split the task
from this CL.

+    LOG(ERROR) << "ManifestService::OpenResource failed:" << file;
+    *fd = -1;
+    return false;
+  }
+
+  *fd = IPC::PlatformFileForTransitToPlatformFile(ipc_fd.descriptor());
+  return true;
+}
+
 }  // namespace ppapi