Implement open_resource in non-SFI mode.

ppapi/nacl_irt/irt_manifest.h

Index: ppapi/nacl_irt/irt_manifest.h
diff --git a/ppapi/nacl_irt/irt_manifest.h b/ppapi/nacl_irt/irt_manifest.h
new file mode 100644
index 0000000000000000000000000000000000000000..4c3a4af58428b7ca7d2a3cfc4dedd4dad6b81969
--- /dev/null
+++ b/ppapi/nacl_irt/irt_manifest.h
@@ -0,0 +1,17 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PPAPI_NACL_IRT_IRT_MANIFEST_H_
+#define PPAPI_NACL_IRT_IRT_MANIFEST_H_
+
+#include "ppapi/proxy/ppapi_proxy_export.h"
+
+namespace ppapi {
+
+// The implementation of irt_open_resource() based on ManifestService.

[dmichael (off chromium), 2014/04/25 21:06:58]

This ought to document what it does and what the return value means.

Also, it's probably more appropriate to rename the "file" parameter to "url"?

[hidehiko, 2014/04/28 08:44:27]

Updated the comment.

As Mark said, the first param is not an actual url, but key.
Please let me keep it as is to be consistent with irt_open_resource().

[dmichael (off chromium), 2014/04/29 17:24:59]

Okay, sorry for the misunderstanding, then.

Perhaps you should document the meaning of the "file" parameter, then?

Also...  what's the long-term goal for the meaning of "IrtOpenResource"? Will it
always be a lookup of a key in the manifest? How do we look up the manifest
itself? Maybe it's OK to be a little bit squishy about what this is for now, but
if it's going to be part of our ABI, we ought to nail down the semantics soon. I
don't think I completely understand the intent right now.

[hidehiko, 2014/04/30 02:26:42]

Done.
My understanding is this is an API to obtain a FD of the resource specified in
the manifest file of "files" section. Mark, any comments?

+PPAPI_PROXY_EXPORT int IrtOpenResource(const char* file, int* fd);
+
+}  // namespace ppapi
+
+#endif  // PPAPI_NACL_IRT_IRT_MANIFEST_H_