Implement open_resource in non-SFI mode.

ppapi/nacl_irt/irt_manifest.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ppapi/nacl_irt/irt_manifest.h"
+
+#include <errno.h>
+
+#include "ppapi/nacl_irt/manifest_service.h"
+#include "ppapi/nacl_irt/plugin_startup.h"
+
+namespace ppapi {
+
+int IrtOpenResource(const char* file, int* fd) {
+  // Remove leading '/' character.
+  if (file[0] == '/')
+    ++file;
+
+  ManifestService* manifest_service = GetManifestService();
+  if (manifest_service == NULL ||
+      !manifest_service->OpenResource(file, fd)) {
+    *fd = -1;

[teravest, 2014/04/24 20:00:52]

Why set |fd| on failure? It seems unnecessary.

[hidehiko, 2014/04/25 05:53:54]

Ok, then let's move this to ManifestService::OpenResource().
As this is called from outside, returning -1 should be safer.

+    return EIO;
+  }
+
+  return (*fd == -1) ? ENOENT : 0;
+}
+
+}  // namespace ppapi