ppapi/nacl_irt/irt_manifest.h - Issue 249183004: Implement open_resource in non-SFI mode.

Side by Side Diff: ppapi/nacl_irt/irt_manifest.h

Issue 249183004: Implement open_resource in non-SFI mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef PPAPI_NACL_IRT_IRT_MANIFEST_H_

	6 #define PPAPI_NACL_IRT_IRT_MANIFEST_H_

	7

	8 #include "ppapi/proxy/ppapi_proxy_export.h"

	9

	10 namespace ppapi {

	11

	12 // The implementation of irt_open_resource() based on ManifestService.
	dmichael (off chromium) 2014/04/25 21:06:58 This ought to document what it does and what the r This ought to document what it does and what the return value means. Also, it's probably more appropriate to rename the "file" parameter to "url"? hidehiko 2014/04/28 08:44:27 Updated the comment. As Mark said, the first para Show quoted text On 2014/04/25 21:06:58, dmichael wrote: > This ought to document what it does and what the return value means. > > Also, it's probably more appropriate to rename the "file" parameter to "url"? Updated the comment. As Mark said, the first param is not an actual url, but key. Please let me keep it as is to be consistent with irt_open_resource(). dmichael (off chromium) 2014/04/29 17:24:59 Okay, sorry for the misunderstanding, then. Perha Show quoted text On 2014/04/28 08:44:27, hidehiko wrote: > On 2014/04/25 21:06:58, dmichael wrote: > > This ought to document what it does and what the return value means. > > > > Also, it's probably more appropriate to rename the "file" parameter to "url"? > > Updated the comment. > > As Mark said, the first param is not an actual url, but key. > Please let me keep it as is to be consistent with irt_open_resource(). Okay, sorry for the misunderstanding, then. Perhaps you should document the meaning of the "file" parameter, then? Also... what's the long-term goal for the meaning of "IrtOpenResource"? Will it always be a lookup of a key in the manifest? How do we look up the manifest itself? Maybe it's OK to be a little bit squishy about what this is for now, but if it's going to be part of our ABI, we ought to nail down the semantics soon. I don't think I completely understand the intent right now. hidehiko 2014/04/30 02:26:42 Done. Show quoted text On 2014/04/29 17:24:59, dmichael wrote: > On 2014/04/28 08:44:27, hidehiko wrote: > > On 2014/04/25 21:06:58, dmichael wrote: > > > This ought to document what it does and what the return value means. > > > > > > Also, it's probably more appropriate to rename the "file" parameter to > "url"? > > > > Updated the comment. > > > > As Mark said, the first param is not an actual url, but key. > > Please let me keep it as is to be consistent with irt_open_resource(). > Okay, sorry for the misunderstanding, then. > > Perhaps you should document the meaning of the "file" parameter, then? Done. Show quoted text > > Also... what's the long-term goal for the meaning of "IrtOpenResource"? Will it > always be a lookup of a key in the manifest? How do we look up the manifest > itself? Maybe it's OK to be a little bit squishy about what this is for now, but > if it's going to be part of our ABI, we ought to nail down the semantics soon. I > don't think I completely understand the intent right now. My understanding is this is an API to obtain a FD of the resource specified in the manifest file of "files" section. Mark, any comments?
	13 PPAPI_PROXY_EXPORT int IrtOpenResource(const char* file, int* fd);

	14

	15 } // namespace ppapi

	16

	17 #endif // PPAPI_NACL_IRT_IRT_MANIFEST_H_

OLD	NEW

« ppapi/api/private/ppb_nacl_private.idl ('K') | « ppapi/c/private/ppb_nacl_private.h ('k') | ppapi/nacl_irt/irt_manifest.cc » ('j') | ppapi/nacl_irt/irt_manifest.cc » ('J')