Implement open_resource in non-SFI mode.

chrome/test/data/nacl/nacl_test_data.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'includes': [
     '../../../../ppapi/ppapi_nacl_test_common.gypi',
   ],
   'targets': [
     {
@@ skipping 1086 matching lines @@
           # testing environment here.
           'copies': [
             {
               'destination': '>(destination_dir)',
               'files': [
                 '>@(test_files)',
               ],
             },
           ],
         },
+        {
+          'target_name': 'nonsfi_irt_manifest_file',
+          'type': 'none',
+          'variables': {
+            'nexe_target': 'irt_manifest_file',
+            'enable_x86_32': 0,
+            'enable_x86_64': 0,
+            'enable_x86_32_nonsfi': 1,
+            'build_pnacl_newlib': 1,
+            # create_nmf.py doesn't support nonsfi.

[Mark Seaborn, 2014/04/26 00:18:59]

How hard would it be to fix that, so that the Gyp files don't get more
complicated?

[hidehiko, 2014/04/28 08:44:27]

It sounds not easy to me.
create_nmf.py parses elf binary to detect its architecture.
For files in "program" section, we probably can add some heuristics to check if
it is for SFI or non-SFI, like checking if ehdr.e_type == ET_DYN, etc.
However, we also need the same thing for .so files, where ehdr.e_type check
doesn't work.
Also, I'm not very sure if checking e_type is appropriate way. Any thought?

Anyway, I'd like to split the task to support non-SFI on create_nmf from this
CL.

[Mark Seaborn, 2014/04/30 21:20:58]

OK, could you do a follow-on change to clean this up, please?  create_nmf could
potentially rely on a file naming convention and/or a command line flag to
distinguish nonsfi binaries.

The current Gyp logic for adding a nonsfi test duplicates a lot and is very hard
to understand, so I wouldn't want any more tests to add more duplication after
this change.

[hidehiko, 2014/05/01 05:20:30]

Sure. Filed a bug, and added TODO with referring the bug.

+            'generate_nmf': 0,
+            'nexe_destination_dir': 'nacl_test_data',
+            'link_flags': [
+              '-lnacl_ppapi_util',
+              '-lppapi_cpp',
+              '-lppapi',
+              '-lnacl',
+            ],
+            'sources': [
+              'manifest_file/irt_manifest_file_test.cc',
+            ],
+            'test_files': [
+              # TODO(ncbray) move into chrome/test/data/nacl when all tests are
+              # converted.
+              '<(DEPTH)/ppapi/native_client/tools/browser_tester/browserdata/nacltest.js',
+              'manifest_file/irt_manifest_file.nmf',
+              'manifest_file/irt_manifest_file_test.html',
+              'manifest_file/test_file.txt',
+            ],
+          },
+          'dependencies': [
+            '<(DEPTH)/native_client/tools.gyp:prep_toolchain',
+            '<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib',
+            '<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib',
+            '<(DEPTH)/native_client/src/untrusted/nacl/nacl.gyp:nacl_lib',
+            'nacl_ppapi_util',
+          ],
+        },
       ],
     }],
   ],
 }