Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2491773006: [compiler] Enable shared function marking by default (Closed)

Created:
4 years, 1 month ago by Leszek Swirski
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Enable shared function marking by default BUG=v8:5512 Committed: https://crrev.com/556217427db010d004dac4fb211b9d750c2e55a8 Cr-Commit-Position: refs/heads/master@{#40920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Leszek Swirski
Let's hope this sticks :)
4 years, 1 month ago (2016-11-11 12:12:12 UTC) #4
Benedikt Meurer
Nice, LGTM, thanks.
4 years, 1 month ago (2016-11-11 12:20:16 UTC) #5
rmcilroy
lgtm
4 years, 1 month ago (2016-11-11 12:21:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491773006/1
4 years, 1 month ago (2016-11-11 12:21:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 13:00:31 UTC) #10
rmcilroy
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2491643006/ by rmcilroy@chromium.org. ...
4 years, 1 month ago (2016-11-11 13:15:07 UTC) #11
rmcilroy
lgtm
4 years, 1 month ago (2016-11-11 15:01:00 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:30:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/556217427db010d004dac4fb211b9d750c2e55a8
Cr-Commit-Position: refs/heads/master@{#40920}

Powered by Google App Engine
This is Rietveld 408576698