Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2491773005: [ios] Removed canGoBack/canGoForward API from CRWSessionController. (Closed)

Created:
4 years, 1 month ago by Eugene But (OOO till 7-30)
Modified:
4 years, 1 month ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed canGoBack/canGoForward API from CRWSessionController. CRWSessionController will be eventually folded into NavigationManager, so existing tests were rewritten to exercise NavigationManager's CanGoBack/CanGoForward API. BUG=661316 Committed: https://crrev.com/a01fff7db87d8570c38a657948f68af0a0e7a3c6 Cr-Commit-Position: refs/heads/master@{#432752}

Patch Set 1 #

Patch Set 2 : Merged with origin/master #

Patch Set 3 : Fixed compilation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -71 lines) Patch
M ios/web/navigation/crw_session_controller.h View 1 1 chunk +2 lines, -6 lines 0 comments Download
M ios/web/navigation/crw_session_controller.mm View 1 1 chunk +0 lines, -8 lines 0 comments Download
M ios/web/navigation/crw_session_controller_unittest.mm View 1 1 chunk +0 lines, -55 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.mm View 1 1 chunk +6 lines, -2 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl_unittest.mm View 1 2 1 chunk +159 lines, -0 lines 0 comments Download
M ios/web/public/navigation_manager.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Eugene But (OOO till 7-30)
4 years, 1 month ago (2016-11-15 00:13:00 UTC) #7
kkhorimoto
lgtm
4 years, 1 month ago (2016-11-16 02:40:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491773005/20001
4 years, 1 month ago (2016-11-17 02:07:51 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/107376) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-11-17 02:34:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491773005/40001
4 years, 1 month ago (2016-11-17 03:18:42 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-17 05:05:34 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 05:08:40 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a01fff7db87d8570c38a657948f68af0a0e7a3c6
Cr-Commit-Position: refs/heads/master@{#432752}

Powered by Google App Engine
This is Rietveld 408576698