[MD Bookmarks] Make the bookmarks extensions API available to MD Bookmarks.

[MD Bookmarks] Make the bookmarks extensions API available to MD Bookmarks.

This CL adds the chrome://bookmarks webui to the allowed users of the
chrome.bookmarks API.

BUG=658980
Committed: https://crrev.com/06087bd8b11b6e75ab272fa5522b8eb1e14e4313
Cr-Commit-Position: refs/heads/master@{#432700}

[calamity, 2016-11-10 07:10:25]

Description was changed from

==========
[MD Bookmarks] Make the bookmarks extensions API available to MD Bookmarks.

BUG=658980
==========

to

==========
[MD Bookmarks] Make the bookmarks extensions API available to MD Bookmarks.

This CL adds the chrome://bookmarks webui to the allowed users of the
chrome.bookmarks API. This required a change to the
bookmarks.import/export api feature definitions because list features
that are parents aren't allowed.

BUG=658980
==========

[calamity, 2016-11-10 07:14:44]

calamity@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[calamity, 2016-11-10 07:14:45]

Hey, I tried just adding stuff as per usual and it broke the build because
SetParent in feature_compiler.py doesn't understand lists as parents. So I
changed the children of bookmarks to be non-parented and copied the parts the
compiler was copying.

Any better ideas?

Thanks.

[Devlin, 2016-11-10 15:57:38]

On 2016/11/10 07:14:45, calamity wrote:
> Hey, I tried just adding stuff as per usual and it broke the build because
> SetParent in feature_compiler.py doesn't understand lists as parents. So I
> changed the children of bookmarks to be non-parented and copied the parts the
> compiler was copying.
> 
> Any better ideas?
> 
> Thanks.

If you want to use a complex feature (list) as the parent, children must specify
the "default_parent" attribute - otherwise, the feature system doesn't know
which parent to inherit from.

For future reference, we (finally!) have documentation for this:
https://chromium.googlesource.com/chromium/src/+/master/chrome/common/extensi...

[calamity, 2016-11-15 02:48:17]

Description was changed from

==========
[MD Bookmarks] Make the bookmarks extensions API available to MD Bookmarks.

This CL adds the chrome://bookmarks webui to the allowed users of the
chrome.bookmarks API. This required a change to the
bookmarks.import/export api feature definitions because list features
that are parents aren't allowed.

BUG=658980
==========

to

==========
[MD Bookmarks] Make the bookmarks extensions API available to MD Bookmarks.

This CL adds the chrome://bookmarks webui to the allowed users of the
chrome.bookmarks API.

BUG=658980
==========

[calamity, 2016-11-15 02:51:02]

Ah cool. Fixed, thanks!

I got confused when the compiler error was at feature_compiler.py:395, saying
deep_copy wasn't available on lists.

Maybe a better error message if the parent is a list would help here too.

[Devlin, 2016-11-15 15:32:40]

On 2016/11/15 02:51:02, calamity wrote:
> Ah cool. Fixed, thanks!
> 
> I got confused when the compiler error was at feature_compiler.py:395, saying
> deep_copy wasn't available on lists.
> 
> Maybe a better error message if the parent is a list would help here too.

Yeah, we should do that. :)  Feel free to file a bug against me!

[Devlin, 2016-11-15 15:33:10]

lgtm

[calamity, 2016-11-15 23:50:27]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-11-15 23:50:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 00:36:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 00:36:13]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[calamity, 2016-11-16 06:41:44]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 06:42:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2016-11-16 06:42:28]

Had to change a test that expected a SimpleFeature but was getting a
ComplexFeature since I changed bookmarks. Just retargeted the test at a
SimpleFeature API.

[commit-bot: I haz the power, 2016-11-16 09:08:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 09:08:09]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-11-16 15:51:56]

On 2016/11/16 06:42:28, calamity wrote:
> Had to change a test that expected a SimpleFeature but was getting a
> ComplexFeature since I changed bookmarks. Just retargeted the test at a
> SimpleFeature API.

s lgtm.

[calamity, 2016-11-17 00:49:28]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-11-17 00:51:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 01:59:28]

Description was changed from

==========
[MD Bookmarks] Make the bookmarks extensions API available to MD Bookmarks.

This CL adds the chrome://bookmarks webui to the allowed users of the
chrome.bookmarks API.

BUG=658980
==========

to

==========
[MD Bookmarks] Make the bookmarks extensions API available to MD Bookmarks.

This CL adds the chrome://bookmarks webui to the allowed users of the
chrome.bookmarks API.

BUG=658980
==========

[commit-bot: I haz the power, 2016-11-17 01:59:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 02:07:19]

Description was changed from

==========
[MD Bookmarks] Make the bookmarks extensions API available to MD Bookmarks.

This CL adds the chrome://bookmarks webui to the allowed users of the
chrome.bookmarks API.

BUG=658980
==========

to

==========
[MD Bookmarks] Make the bookmarks extensions API available to MD Bookmarks.

This CL adds the chrome://bookmarks webui to the allowed users of the
chrome.bookmarks API.

BUG=658980

Committed: https://crrev.com/06087bd8b11b6e75ab272fa5522b8eb1e14e4313
Cr-Commit-Position: refs/heads/master@{#432700}
==========

[commit-bot: I haz the power, 2016-11-17 02:07:20]

Patchset 3 (id:??) landed as
https://crrev.com/06087bd8b11b6e75ab272fa5522b8eb1e14e4313
Cr-Commit-Position: refs/heads/master@{#432700}