Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Issue 2491773002: Page Info (Views): remove images from accessibility order (Closed)
Patch Set: Address latest comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/views/website_settings/permission_selector_row.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h " 5 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h "
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/i18n/rtl.h" 12 #include "base/i18n/rtl.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "base/memory/ptr_util.h" 14 #include "base/memory/ptr_util.h"
15 #include "base/strings/string16.h" 15 #include "base/strings/string16.h"
16 #include "base/strings/string_util.h" 16 #include "base/strings/string_util.h"
17 #include "base/strings/utf_string_conversions.h" 17 #include "base/strings/utf_string_conversions.h"
18 #include "chrome/browser/certificate_viewer.h" 18 #include "chrome/browser/certificate_viewer.h"
19 #include "chrome/browser/devtools/devtools_toggle_action.h" 19 #include "chrome/browser/devtools/devtools_toggle_action.h"
20 #include "chrome/browser/devtools/devtools_window.h" 20 #include "chrome/browser/devtools/devtools_window.h"
21 #include "chrome/browser/infobars/infobar_service.h" 21 #include "chrome/browser/infobars/infobar_service.h"
22 #include "chrome/browser/profiles/profile.h" 22 #include "chrome/browser/profiles/profile.h"
23 #include "chrome/browser/ui/browser.h" 23 #include "chrome/browser/ui/browser.h"
24 #include "chrome/browser/ui/browser_dialogs.h" 24 #include "chrome/browser/ui/browser_dialogs.h"
25 #include "chrome/browser/ui/layout_constants.h" 25 #include "chrome/browser/ui/layout_constants.h"
26 #include "chrome/browser/ui/views/collected_cookies_views.h" 26 #include "chrome/browser/ui/views/collected_cookies_views.h"
27 #include "chrome/browser/ui/views/website_settings/chosen_object_row.h" 27 #include "chrome/browser/ui/views/website_settings/chosen_object_row.h"
28 #include "chrome/browser/ui/views/website_settings/non_accessible_image_view.h"
28 #include "chrome/browser/ui/views/website_settings/permission_selector_row.h" 29 #include "chrome/browser/ui/views/website_settings/permission_selector_row.h"
29 #include "chrome/browser/ui/website_settings/website_settings.h" 30 #include "chrome/browser/ui/website_settings/website_settings.h"
30 #include "chrome/common/pref_names.h" 31 #include "chrome/common/pref_names.h"
31 #include "chrome/common/url_constants.h" 32 #include "chrome/common/url_constants.h"
32 #include "chrome/grit/chromium_strings.h" 33 #include "chrome/grit/chromium_strings.h"
33 #include "chrome/grit/generated_resources.h" 34 #include "chrome/grit/generated_resources.h"
34 #include "chrome/grit/theme_resources.h" 35 #include "chrome/grit/theme_resources.h"
35 #include "components/content_settings/core/common/content_settings_types.h" 36 #include "components/content_settings/core/common/content_settings_types.h"
36 #include "components/prefs/pref_service.h" 37 #include "components/prefs/pref_service.h"
37 #include "components/strings/grit/components_chromium_strings.h" 38 #include "components/strings/grit/components_chromium_strings.h"
(...skipping 324 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 } 363 }
363 364
364 // Compensate for built-in vertical padding in the anchor view's image. 365 // Compensate for built-in vertical padding in the anchor view's image.
365 set_anchor_view_insets(gfx::Insets( 366 set_anchor_view_insets(gfx::Insets(
366 GetLayoutConstant(LOCATION_BAR_BUBBLE_ANCHOR_VERTICAL_INSET), 0)); 367 GetLayoutConstant(LOCATION_BAR_BUBBLE_ANCHOR_VERTICAL_INSET), 0));
367 368
368 const int kSpacing = 16; 369 const int kSpacing = 16;
369 SetLayoutManager(new views::BoxLayout(views::BoxLayout::kHorizontal, kSpacing, 370 SetLayoutManager(new views::BoxLayout(views::BoxLayout::kHorizontal, kSpacing,
370 kSpacing, kSpacing)); 371 kSpacing, kSpacing));
371 set_margins(gfx::Insets()); 372 set_margins(gfx::Insets());
372 views::ImageView* icon_view = new views::ImageView(); 373 views::ImageView* icon_view = new NonAccessibleImageView();
373 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); 374 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
374 icon_view->SetImage(rb.GetImageSkiaNamed(icon)); 375 icon_view->SetImage(rb.GetImageSkiaNamed(icon));
375 AddChildView(icon_view); 376 AddChildView(icon_view);
376 377
377 views::Label* label = new views::Label(l10n_util::GetStringUTF16(text)); 378 views::Label* label = new views::Label(l10n_util::GetStringUTF16(text));
378 label->SetMultiLine(true); 379 label->SetMultiLine(true);
379 label->SetAllowCharacterBreak(true); 380 label->SetAllowCharacterBreak(true);
380 label->SetHorizontalAlignment(gfx::ALIGN_LEFT); 381 label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
381 AddChildView(label); 382 AddChildView(label);
382 383
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
612 613
613 layout->AddPaddingRow(0, kCookiesViewVerticalPadding); 614 layout->AddPaddingRow(0, kCookiesViewVerticalPadding);
614 615
615 layout->StartRow(1, cookies_view_column); 616 layout->StartRow(1, cookies_view_column);
616 WebsiteSettingsUI::PermissionInfo info; 617 WebsiteSettingsUI::PermissionInfo info;
617 info.type = CONTENT_SETTINGS_TYPE_COOKIES; 618 info.type = CONTENT_SETTINGS_TYPE_COOKIES;
618 info.setting = CONTENT_SETTING_ALLOW; 619 info.setting = CONTENT_SETTING_ALLOW;
619 info.is_incognito = 620 info.is_incognito =
620 Profile::FromBrowserContext(web_contents()->GetBrowserContext()) 621 Profile::FromBrowserContext(web_contents()->GetBrowserContext())
621 ->IsOffTheRecord(); 622 ->IsOffTheRecord();
622 views::ImageView* icon = new views::ImageView(); 623 views::ImageView* icon = new NonAccessibleImageView();
623 const gfx::Image& image = WebsiteSettingsUI::GetPermissionIcon(info); 624 const gfx::Image& image = WebsiteSettingsUI::GetPermissionIcon(info);
624 icon->SetImage(image.ToImageSkia()); 625 icon->SetImage(image.ToImageSkia());
625 layout->AddView( 626 layout->AddView(
626 icon, 1, 2, views::GridLayout::FILL, 627 icon, 1, 2, views::GridLayout::FILL,
627 // TODO: The vertical alignment may change to CENTER once Harmony is 628 // TODO: The vertical alignment may change to CENTER once Harmony is
628 // implemented. See https://crbug.com/512442#c48 629 // implemented. See https://crbug.com/512442#c48
629 views::GridLayout::LEADING); 630 views::GridLayout::LEADING);
630 631
631 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); 632 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
632 const gfx::FontList& font_list = rb.GetFontListWithDelta(1); 633 const gfx::FontList& font_list = rb.GetFontListWithDelta(1);
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
802 } 803 }
803 break; 804 break;
804 case STYLED_LABEL_RESET_CERTIFICATE_DECISIONS: 805 case STYLED_LABEL_RESET_CERTIFICATE_DECISIONS:
805 presenter_->OnRevokeSSLErrorBypassButtonPressed(); 806 presenter_->OnRevokeSSLErrorBypassButtonPressed();
806 GetWidget()->Close(); 807 GetWidget()->Close();
807 break; 808 break;
808 default: 809 default:
809 NOTREACHED(); 810 NOTREACHED();
810 } 811 }
811 } 812 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/website_settings/permission_selector_row.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698