chrome/browser/ui/views/website_settings/non_accessible_image_view.h - Issue 2491773002: Page Info (Views): remove images from accessibility order

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/website_settings/non_accessible_image_view.h

Issue 2491773002: Page Info (Views): remove images from accessibility order (Closed)

Patch Set: Move NonAccessibleImageView into a new class. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/views/website_settings/non_accessible_image_view.cc » ('j') | chrome/browser/ui/views/website_settings/non_accessible_image_view.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
	msw 2016/11/11 15:55:01 nit: no (c) for new files; ditto in cc file nit: no (c) for new files; ditto in cc file lgarron 2016/11/11 22:28:51 Done. (Took me a while to figure out you meant to Show quoted text On 2016/11/11 at 15:55:01, msw wrote: > nit: no (c) for new files; ditto in cc file Done. (Took me a while to figure out you meant to just take out the symbol "(c)", not the whole copyright line. I can't find a wiki page about creating files; how can I find out about details like this?) msw 2016/11/11 22:34:23 Sorry for being unclear... our C++ style guide exp Show quoted text On 2016/11/11 22:28:51, lgarron wrote: > On 2016/11/11 at 15:55:01, msw wrote: > > nit: no (c) for new files; ditto in cc file > > Done. > > (Took me a while to figure out you meant to just take out the symbol "(c)", not > the whole copyright line. I can't find a wiki page about creating files; how can > I find out about details like this?) Sorry for being unclear... our C++ style guide explains this: https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_NON_ACCESSIBLE_IMAGE_VIEW_H_

	6 #define CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_NON_ACCESSIBLE_IMAGE_VIEW_H_

	7

	8 #include "base/macros.h"

	9 #include "ui/accessibility/ax_enums.h"
	msw 2016/11/11 15:55:01 nit: move to cc file nit: move to cc file lgarron 2016/11/11 22:28:50 Done. Show quoted text On 2016/11/11 at 15:55:01, msw wrote: > nit: move to cc file Done.
	10 #include "ui/accessibility/ax_node_data.h"
	msw 2016/11/11 15:55:01 optional nit: rely on the transitive include/forwa optional nit: rely on the transitive include/forward-decl from image_view.h lgarron 2016/11/11 22:28:51 Done. Show quoted text On 2016/11/11 at 15:55:01, msw wrote: > optional nit: rely on the transitive include/forward-decl from image_view.h Done.
	11 #include "ui/views/controls/image_view.h"

	12

	13 class NonAccessibleImageView : public views::ImageView {

	14 public:

	15 NonAccessibleImageView() {}

	16 ~NonAccessibleImageView() override {}

	17

	18 private:

	19 // Overridden from views::ImageView.

	20 void GetAccessibleNodeData(ui::AXNodeData* node_data) override;

	21

	22 DISALLOW_COPY_AND_ASSIGN(NonAccessibleImageView);

	23 };

	24

	25 #endif // CHROME_BROWSER_UI_VIEWS_WEBSITE_SETTINGS_NON_ACCESSIBLE_IMAGE_VIEW_H_

OLD	NEW