chrome/browser/ui/views/website_settings/non_accessible_image_view.cc - Issue 2491773002: Page Info (Views): remove images from accessibility order

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/website_settings/non_accessible_image_view.cc

Issue 2491773002: Page Info (Views): remove images from accessibility order (Closed)

Patch Set: Move NonAccessibleImageView into a new class. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/ui/views/website_settings/non_accessible_image_view.h"

	6

	7 void NonAccessibleImageView::GetAccessibleNodeData(ui::AXNodeData* node_data) {

	8 node_data->role = ui::AX_ROLE_IGNORED;
	msw 2016/11/11 15:55:01 Please address Dominic's feedback: node_data->AddS Please address Dominic's feedback: node_data->AddStateFlag(ui::AX_STATE_INVISIBLE). lgarron 2016/11/11 22:28:50 Done. node_data->AddStateFlag(ui::AX_STATE_INVISI Show quoted text On 2016/11/11 at 15:55:01, msw wrote: > Please address Dominic's feedback: node_data->AddStateFlag(ui::AX_STATE_INVISIBLE). Done. node_data->AddStateFlag(ui::AX_STATE_INVISIBLE) appears to be sufficient, so I've switched to that. dmazzoni@, is it appropriate to set the state to invisible and leave the role as image?
	9 }

OLD	NEW