Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 2491763003: Revert of Removing the ChildProcessHostMsg_SyncAllocateSharedMemory IPC message. (Closed)

Created:
4 years, 1 month ago by vabr (Chromium)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Removing the ChildProcessHostMsg_SyncAllocateSharedMemory IPC message. (patchset #3 id:40001 of https://codereview.chromium.org/2478343002/ ) Reason for revert: This is causing crashes in fast/hidpi/scrollbar-appearance-increase-device-scale-factor.html, more info in http://crbug.com/612500#c71. Original issue's description: > Replacing the ChildProcessHostMsg_SyncAllocateSharedMemory IPC message > with a Mojo shared buffer. Mojo shared buffers automatically delegate > to a privileged process using an internal sync IPC if necessary when > instanciated, hence the simplification here. > > BUG=612500 > > Committed: https://crrev.com/f42b5afcda825dbd4d9e278082c24578866d3c31 > Cr-Commit-Position: refs/heads/master@{#431130} TBR=rockot@chromium.org,nasko@chromium.org,jcivelli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612500 Committed: https://crrev.com/0ae3afa991b953ada3e87fb2c44c65560d8b4196 Cr-Commit-Position: refs/heads/master@{#431219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -22 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 2 chunks +24 lines, -3 lines 0 comments Download
M content/child/child_thread_impl.cc View 2 chunks +18 lines, -16 lines 0 comments Download
M content/common/child_process_host_impl.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/common/child_process_host_impl.cc View 3 chunks +24 lines, -3 lines 0 comments Download
M content/common/child_process_messages.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
vabr (Chromium)
Created Revert of Removing the ChildProcessHostMsg_SyncAllocateSharedMemory IPC message.
4 years, 1 month ago (2016-11-10 09:15:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491763003/1
4 years, 1 month ago (2016-11-10 09:16:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 09:18:40 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 09:22:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ae3afa991b953ada3e87fb2c44c65560d8b4196
Cr-Commit-Position: refs/heads/master@{#431219}

Powered by Google App Engine
This is Rietveld 408576698