Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2491753003: Re-enable assert to check canonicalization of signature type after snapshot (Closed)

Created:
4 years, 1 month ago by regis
Modified:
4 years, 1 month ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-enable assert to check canonicalization of signature type after snapshot generation. See issue #27606 for details, and reopen if assert triggers. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/e0b7792668e83c02492ef6509b8e7cb5b35c7add

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
4 years, 1 month ago (2016-11-09 22:57:19 UTC) #2
rmacnak
lgtm
4 years, 1 month ago (2016-11-10 00:13:46 UTC) #3
regis
4 years, 1 month ago (2016-11-10 18:12:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e0b7792668e83c02492ef6509b8e7cb5b35c7add (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698