Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2491733002: Add data usage tracking for cloud print, update client service and search provide logos (Closed)

Created:
4 years, 1 month ago by Raj
Modified:
4 years, 1 month ago
CC:
asvitkine+watch_chromium.org, blundell+watchlist_chromium.org, chromium-reviews, droger+watchlist_chromium.org, sdefresne+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add data usage tracking for cloud print, update client service and search provide logos BUG=655749 Committed: https://crrev.com/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9 Cr-Commit-Position: refs/heads/master@{#432963}

Patch Set 1 #

Patch Set 2 : Add update client service #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -4 lines) Patch
M chrome/browser/printing/cloud_print/gcd_api_flow_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/printing/cloud_print/privet_url_fetcher.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/service/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/data_use_measurement/core/data_use_user_data.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/data_use_measurement/core/data_use_user_data.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M components/search_provider_logos/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/search_provider_logos/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/search_provider_logos/logo_tracker.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/update_client/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/update_client/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/update_client/url_fetcher_downloader.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M components/update_client/utils.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
Raj
gene: ptal chrome/browser/printing/cloud_print/* and chrome/service/cloud_print/* ianwen: ptal components/search_provider_logos/*
4 years, 1 month ago (2016-11-09 22:09:02 UTC) #2
Ian Wen
lgtm
4 years, 1 month ago (2016-11-10 01:15:37 UTC) #3
Raj
scottbyer: ptal chrome/browser/printing/cloud_print/* and chrome/service/cloud_print/* kundaji: ptal components/data_use_measurement/core/
4 years, 1 month ago (2016-11-15 20:09:17 UTC) #5
Raj
waffles: ptal components/update_client/*
4 years, 1 month ago (2016-11-15 20:44:06 UTC) #8
waffles
On 2016/11/15 20:44:06, Raj wrote: > waffles: ptal components/update_client/* On Windows, we also use BITS ...
4 years, 1 month ago (2016-11-15 23:16:02 UTC) #9
waffles
On 2016/11/15 23:16:02, waffles wrote: > On 2016/11/15 20:44:06, Raj wrote: > > waffles: ptal ...
4 years, 1 month ago (2016-11-15 23:20:58 UTC) #10
Raj
On 2016/11/15 23:20:58, waffles wrote: > On 2016/11/15 23:16:02, waffles wrote: > > On 2016/11/15 ...
4 years, 1 month ago (2016-11-15 23:27:51 UTC) #11
Raj
rkaplow: ptal tools/metrics/histograms/histograms.xml
4 years, 1 month ago (2016-11-16 00:20:42 UTC) #13
rkaplow
lgtm
4 years, 1 month ago (2016-11-16 06:11:39 UTC) #14
Scott Byer
lgtm
4 years, 1 month ago (2016-11-17 18:27:36 UTC) #15
Not at Google. Contact bengr
lgtm components/data_use_measurement/* LGTM
4 years, 1 month ago (2016-11-17 18:52:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491733002/40001
4 years, 1 month ago (2016-11-17 20:48:58 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-17 21:30:09 UTC) #24
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 21:32:53 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2ca4b1f9ec2d34c10b8147a43c8c781112c68ae9
Cr-Commit-Position: refs/heads/master@{#432963}

Powered by Google App Engine
This is Rietveld 408576698