Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2491713003: Fix sizing of tray details scroll views. (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix sizing of tray details scroll views. I tried to make this code make more sense, but touching scroll views is always a bit like Jenga so in the end I went for the minimal change that fixes the observed bug. (The fragile code is something that we inherited from the pre-MD layout.) BUG=663790 Committed: https://crrev.com/dcd3a8aae5f2f849b50b31d95ae7802eaf5db484 Cr-Commit-Position: refs/heads/master@{#431161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/common/system/tray/tray_details_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
tdanderson
LGTM
4 years, 1 month ago (2016-11-10 01:50:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491713003/1
4 years, 1 month ago (2016-11-10 03:09:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 03:16:11 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 03:19:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dcd3a8aae5f2f849b50b31d95ae7802eaf5db484
Cr-Commit-Position: refs/heads/master@{#431161}

Powered by Google App Engine
This is Rietveld 408576698