Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2491713002: DBC: Add missing PC descriptors in static initializers. (Closed)

Created:
4 years, 1 month ago by Florian Schneider
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DBC: Add missing PC descriptors in static initializers. InitStatic can call, and may throw. Therefore we need to mark it as a call. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/dc6aaadba96180cbcec0bf2a5de0b5354e8e0341

Patch Set 1 #

Patch Set 2 : small fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M runtime/vm/intermediate_language_dbc.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
4 years, 1 month ago (2016-11-17 01:16:00 UTC) #3
Vyacheslav Egorov (Google)
lgtm
4 years, 1 month ago (2016-11-17 16:21:11 UTC) #4
Florian Schneider
4 years, 1 month ago (2016-11-17 18:30:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dc6aaadba96180cbcec0bf2a5de0b5354e8e0341 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698