Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 2491703004: Replace roundedLayoutPoint with LayoutPoint (Closed)

Created:
4 years, 1 month ago by xing.xu
Modified:
4 years, 1 month ago
Reviewers:
mustaq, Stephen White, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, fs, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, krit, drott+blinkwatch_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, jchaffraix+rendering, Navid Zolghadr, blink-reviews, gyuyoung2, rwlbuis, ajuma+watch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, sof, jbroman, pdr+graphicswatchlist_chromium.org, danakj+watch_chromium.org, dtapuska+blinkwatch_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, blink-reviews-paint_chromium.org, f(malita), Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace roundedLayoutPoint with LayoutPoint roundedLayoutPoint is a noop. And crbug.com/321237 is fixed, so also remove related FIXME. BUG=663895 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/c8906d8c65b7ca22d648fdacda5f01af12a11cb9 Cr-Commit-Position: refs/heads/master@{#431408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -28 lines) Patch
M third_party/WebKit/Source/core/dom/Touch.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/MouseRelatedEvent.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/TouchEventManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/LayoutPoint.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
xing.xu
PTAL, thanks.
4 years, 1 month ago (2016-11-10 03:31:12 UTC) #9
Stephen White
LGTM, but eae@ should probably do a quick once-over
4 years, 1 month ago (2016-11-10 14:22:27 UTC) #13
eae
RS-LGTM, thank you.
4 years, 1 month ago (2016-11-10 23:40:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491703004/1
4 years, 1 month ago (2016-11-10 23:40:59 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 00:29:15 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 00:31:58 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8906d8c65b7ca22d648fdacda5f01af12a11cb9
Cr-Commit-Position: refs/heads/master@{#431408}

Powered by Google App Engine
This is Rietveld 408576698