Create a subset of skia support for paths only

Create a subset of skia support for paths only

This is a continuation of https://codereview.chromium.org/2346483006/

This removes the need for agg, without providing
full Skia support.

It doesn't work yet, but it does compile and run
for simple PDFs.

R=dsinclair@google.com

Committed: https://pdfium.googlesource.com/pdfium/+/5d223298b26c9b2b6284cba9a51521d3873b6e58
Committed: https://pdfium.googlesource.com/pdfium/+/af177fe1c062d20b663a4a1c14924be85d0e631e

[caryclark, 2016-11-09 20:21:36]

(For some reason, I was unable to continue the old patch from some months back.)

This rebases the old CL against the current code, and addresses the comments
from the old review.

I don't know yet if it is faster or slower than agg, because it doesn't draw the
same, yet. Once I get the rendering bugs worked out, I'll measure performance.

[caryclark, 2016-11-09 20:21:51]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 20:22:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-11-09 20:23:18]

Description was changed from

==========
rebase with tip of tree

This is a continuation of https://codereview.chromium.org/2346483006/

Create a subset of skia support for paths only

This removes the need for agg, without providing
full Skia support.

It doesn't work yet, but it does compile and run
for simple PDFs.

R=dsinclair@google.com
==========

to

==========
Create a subset of skia support for paths only

This is a continuation of https://codereview.chromium.org/2346483006/

This removes the need for agg, without providing
full Skia support.

It doesn't work yet, but it does compile and run
for simple PDFs.

R=dsinclair@google.com
==========

[dsinclair, 2016-11-09 20:26:24]

dsinclair@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2016-11-09 20:26:24]

lgtm

[caryclark, 2016-11-14 18:27:34]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 18:27:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caryclark, 2016-11-14 18:31:32]

I'm ready to commit this for real now.

Locally this crashed when running run_corpus_tests.py; I wanted to fix this
before submitting it. After a lot of frustrating Python debugging, I ran ninja
to build everything; subsequently, the test ran without crashing.

The failures reported by run_corpus_tests.py appear to be a mix of real bugs and
invisible pixel differences. To help with this, I'll work with the Skia Infra
team to get their pixel difference tool (Gold) running with the pdfium test
corpus.

[commit-bot: I haz the power, 2016-11-14 18:47:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 18:47:10]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-11-14 20:55:10]

Looks like this breaks the skia bots?

[caryclark, 2016-11-14 21:40:57]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 21:41:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caryclark, 2016-11-14 21:42:36]

On 2016/11/14 20:55:10, dsinclair wrote:
> Looks like this breaks the skia bots?

Whoops. Hopefully fixed this time.

[dsinclair, 2016-11-14 21:55:31]

lgtm

[commit-bot: I haz the power, 2016-11-14 22:28:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 22:28:37]

Dry run: This issue passed the CQ dry run.

[caryclark, 2016-11-15 13:23:52]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2016-11-15 13:23:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 13:24:15]

Description was changed from

==========
Create a subset of skia support for paths only

This is a continuation of https://codereview.chromium.org/2346483006/

This removes the need for agg, without providing
full Skia support.

It doesn't work yet, but it does compile and run
for simple PDFs.

R=dsinclair@google.com
==========

to

==========
Create a subset of skia support for paths only

This is a continuation of https://codereview.chromium.org/2346483006/

This removes the need for agg, without providing
full Skia support.

It doesn't work yet, but it does compile and run
for simple PDFs.

R=dsinclair@google.com

Committed:
https://pdfium.googlesource.com/pdfium/+/5d223298b26c9b2b6284cba9a51521d3873b...
==========

[commit-bot: I haz the power, 2016-11-15 13:24:16]

Committed patchset #10 (id:180001) as
https://pdfium.googlesource.com/pdfium/+/5d223298b26c9b2b6284cba9a51521d3873b...

[dsinclair, 2016-11-15 15:44:16]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/2503883003/ by dsinclair@chromium.org.

The reason for reverting is: Breaking the chrome roll.

https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_com....

[caryclark, 2016-11-16 17:53:47]

Chrome change to build overrides has landed. Will try to land this again.

[caryclark, 2016-11-16 17:53:58]

Description was changed from

==========
Create a subset of skia support for paths only

This is a continuation of https://codereview.chromium.org/2346483006/

This removes the need for agg, without providing
full Skia support.

It doesn't work yet, but it does compile and run
for simple PDFs.

R=dsinclair@google.com

Committed:
https://pdfium.googlesource.com/pdfium/+/5d223298b26c9b2b6284cba9a51521d3873b...
==========

to

==========
Create a subset of skia support for paths only

This is a continuation of https://codereview.chromium.org/2346483006/

This removes the need for agg, without providing
full Skia support.

It doesn't work yet, but it does compile and run
for simple PDFs.

R=dsinclair@google.com

Committed:
https://pdfium.googlesource.com/pdfium/+/5d223298b26c9b2b6284cba9a51521d3873b...
==========

[caryclark, 2016-11-16 17:54:23]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2016-11-16 17:54:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 18:10:06]

Description was changed from

==========
Create a subset of skia support for paths only

This is a continuation of https://codereview.chromium.org/2346483006/

This removes the need for agg, without providing
full Skia support.

It doesn't work yet, but it does compile and run
for simple PDFs.

R=dsinclair@google.com

Committed:
https://pdfium.googlesource.com/pdfium/+/5d223298b26c9b2b6284cba9a51521d3873b...
==========

to

==========
Create a subset of skia support for paths only

This is a continuation of https://codereview.chromium.org/2346483006/

This removes the need for agg, without providing
full Skia support.

It doesn't work yet, but it does compile and run
for simple PDFs.

R=dsinclair@google.com

Committed:
https://pdfium.googlesource.com/pdfium/+/5d223298b26c9b2b6284cba9a51521d3873b...
Committed:
https://pdfium.googlesource.com/pdfium/+/af177fe1c062d20b663a4a1c14924be85d0e...
==========

[commit-bot: I haz the power, 2016-11-16 18:10:08]

Committed patchset #10 (id:180001) as
https://pdfium.googlesource.com/pdfium/+/af177fe1c062d20b663a4a1c14924be85d0e...