Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2491643006: Revert of [compiler] Enable shared function marking by default (Closed)

Created:
4 years, 1 month ago by rmcilroy
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [compiler] Enable shared function marking by default (patchset #1 id:1 of https://codereview.chromium.org/2491773006/ ) Reason for revert: Revert because it depends on https://codereview.chromium.org/2478323002/ which has been reverted. Original issue's description: > [compiler] Enable shared function marking by default > > BUG=v8:5512 TBR=bmeurer@chromium.org,leszeks@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5512 Committed: https://crrev.com/7b1a0484077c204504c016cc0178d293ca324a70 Cr-Commit-Position: refs/heads/master@{#40926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rmcilroy
Created Revert of [compiler] Enable shared function marking by default
4 years, 1 month ago (2016-11-11 13:15:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491643006/1
4 years, 1 month ago (2016-11-11 13:15:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 13:15:29 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:30:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b1a0484077c204504c016cc0178d293ca324a70
Cr-Commit-Position: refs/heads/master@{#40926}

Powered by Google App Engine
This is Rietveld 408576698