Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2491623003: Show realm in device owner notice (Closed)

Created:
4 years, 1 month ago by Roman Sorokin (ftl)
Modified:
4 years, 1 month ago
Reviewers:
Thiemo Nagel, oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show realm in device owner notice Show Active Directory domain (realm) in the owner notice for the devices enrolled to Active Directory management. BUG=663694 TEST=manual Committed: https://crrev.com/fb20bb44c9677645d8dc35f27ba352b08d331b6d Cr-Commit-Position: refs/heads/master@{#431280}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M ash/common/system/tray/system_tray_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/common/system/tray/system_tray_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 2 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
Roman Sorokin (ftl)
Thiemo, please take a look.
4 years, 1 month ago (2016-11-10 11:07:00 UTC) #2
Thiemo Nagel
lgtm
4 years, 1 month ago (2016-11-10 12:18:22 UTC) #9
Roman Sorokin (ftl)
Hey oshima@, please take a look
4 years, 1 month ago (2016-11-10 12:22:05 UTC) #11
oshima
lgtm
4 years, 1 month ago (2016-11-10 16:48:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491623003/20001
4 years, 1 month ago (2016-11-10 17:13:43 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 17:18:32 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 17:37:38 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fb20bb44c9677645d8dc35f27ba352b08d331b6d
Cr-Commit-Position: refs/heads/master@{#431280}

Powered by Google App Engine
This is Rietveld 408576698