content/browser/service_worker/service_worker_job_unittest.cc - Issue 2491613004: Make base::Timer sequence-friendly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_job_unittest.cc

Issue 2491613004: Make base::Timer sequence-friendly. (Closed)

Patch Set: add back commented out DCHECK in Stop() Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_job_unittest.cc b/content/browser/service_worker/service_worker_job_unittest.cc

index ca7aea2857325ccbbf59af4b24cbd76eff317ef4..135347b82e78634199127fc2082a13071f1d3d83 100644

--- a/content/browser/service_worker/service_worker_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_job_unittest.cc

@@ -1800,7 +1800,7 @@ TEST_F(ServiceWorkerJobTest, ActivateCancelsOnShutdown) {

// Allow the activation to continue. It will fail, and the worker

// should not be promoted to ACTIVATED because failure occur

// during shutdown.

- runner->RunUntilIdle();

+ runner->RunPendingTasks();

base::RunLoop().RunUntilIdle();

EXPECT_EQ(new_version.get(), registration->active_version());

EXPECT_EQ(ServiceWorkerVersion::ACTIVATING, new_version->status());