Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2491593003: Remove deprecated members from ErrorCode. (Closed)

Created:
4 years, 1 month ago by Paul Berry
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove deprecated members from ErrorCode. These existed as an effort to avoid causing breaking changes in the analyzer package, but it turns out that the analyzer package already has breaking changes in progress, so there is no benefit. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/981e2660bf526224364b58dcb94a1a8914ee0ca5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M pkg/front_end/lib/src/scanner/errors.dart View 3 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
I know you were going to work on removing @deprecated stuff, but these are blocking ...
4 years, 1 month ago (2016-11-09 23:29:08 UTC) #2
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-10 00:04:47 UTC) #3
Paul Berry
4 years, 1 month ago (2016-11-10 02:12:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
981e2660bf526224364b58dcb94a1a8914ee0ca5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698