Tidy fpdfsdk/fpdf_flatten.cpp

Tidy fpdfsdk/fpdf_flatten.cpp

Remove CFX_ArrayTemplate usage.
Use std::min(), std::max() in a few places.

Committed: https://pdfium.googlesource.com/pdfium/+/6173c9d2a3ce717b1ea3bfa12d6d403ee6a543a6

[Tom Sepez, 2016-11-09 21:32:59]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 21:33:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-11-09 21:34:05]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-11-09 21:34:06]

Lei, ready for review.

https://codereview.chromium.org/2491583003/diff/1/fpdfsdk/fpdf_flatten.cpp
File fpdfsdk/fpdf_flatten.cpp (right):

https://codereview.chromium.org/2491583003/diff/1/fpdfsdk/fpdf_flatten.cpp#ne...
fpdfsdk/fpdf_flatten.cpp:265: rcMerger.left = std::max(rcMerger.left,
rcOriginalMB.left);
Note: Doublecheck my logic here.

[Lei Zhang, 2016-11-09 22:10:20]

https://codereview.chromium.org/2491583003/diff/1/fpdfsdk/fpdf_flatten.cpp
File fpdfsdk/fpdf_flatten.cpp (right):

https://codereview.chromium.org/2491583003/diff/1/fpdfsdk/fpdf_flatten.cpp#ne...
fpdfsdk/fpdf_flatten.cpp:124: int nRects = pdfium::CollectionSize<int>(array);
Can we just do size_t everywhere?

https://codereview.chromium.org/2491583003/diff/1/fpdfsdk/fpdf_flatten.cpp#ne...
fpdfsdk/fpdf_flatten.cpp:128: std::unique_ptr<FX_FLOAT[]> pArray(new
FX_FLOAT[nRects]);
std::vector?

https://codereview.chromium.org/2491583003/diff/1/fpdfsdk/fpdf_flatten.cpp#ne...
fpdfsdk/fpdf_flatten.cpp:154: if (fRet <= pArray[i])
More opportunities for std::max / min?

[Tom Sepez, 2016-11-09 22:28:22]

https://codereview.chromium.org/2491583003/diff/1/fpdfsdk/fpdf_flatten.cpp
File fpdfsdk/fpdf_flatten.cpp (right):

https://codereview.chromium.org/2491583003/diff/1/fpdfsdk/fpdf_flatten.cpp#ne...
fpdfsdk/fpdf_flatten.cpp:124: int nRects = pdfium::CollectionSize<int>(array);
On 2016/11/09 22:10:20, Lei Zhang (slow) wrote:
> Can we just do size_t everywhere?

Done.

https://codereview.chromium.org/2491583003/diff/1/fpdfsdk/fpdf_flatten.cpp#ne...
fpdfsdk/fpdf_flatten.cpp:128: std::unique_ptr<FX_FLOAT[]> pArray(new
FX_FLOAT[nRects]);
On 2016/11/09 22:10:20, Lei Zhang (slow) wrote:
> std::vector?

Done.

https://codereview.chromium.org/2491583003/diff/1/fpdfsdk/fpdf_flatten.cpp#ne...
fpdfsdk/fpdf_flatten.cpp:154: if (fRet <= pArray[i])
On 2016/11/09 22:10:20, Lei Zhang (slow) wrote:
> More opportunities for std::max / min?

Done.

[Lei Zhang, 2016-11-09 23:06:35]

lgtm

[Tom Sepez, 2016-11-09 23:28:32]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-11-09 23:28:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 00:38:05]

Description was changed from

==========
Tidy fpdfsdk/fpdf_flatten.cpp

Remove CFX_ArrayTemplate usage.
Use std::min(), std::max() in a few places.
==========

to

==========
Tidy fpdfsdk/fpdf_flatten.cpp

Remove CFX_ArrayTemplate usage.
Use std::min(), std::max() in a few places.

Committed:
https://pdfium.googlesource.com/pdfium/+/6173c9d2a3ce717b1ea3bfa12d6d403ee6a5...
==========

[commit-bot: I haz the power, 2016-11-10 00:38:06]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/6173c9d2a3ce717b1ea3bfa12d6d403ee6a5...