Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2491573002: Adds chromecast-internal interfaces to service:content_browser manifest. (Closed)

Created:
4 years, 1 month ago by alokp
Modified:
4 years, 1 month ago
Reviewers:
slan, halliwell
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds chromecast-internal interfaces to service:content_browser manifest. It should ideally be added to an internal manifest, but I am not sure how to overlay an overlay manifest. It is also temporary since they will be moved to service:chromecast manifest anyways when it is ready. It is needed now to make cast_shell_browser_test pass on internal bots. BUG=663067 TBR=slan@chromium.org Committed: https://crrev.com/8289cd23314eed08cf185fefa5f52727f46bccfb Cr-Commit-Position: refs/heads/master@{#430974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chromecast/browser/cast_content_browser_manifest_overlay.json View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
alokp
Will TBR since it is needed to roll chromium.
4 years, 1 month ago (2016-11-09 17:56:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491573002/1
4 years, 1 month ago (2016-11-09 17:57:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 18:06:41 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 18:18:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8289cd23314eed08cf185fefa5f52727f46bccfb
Cr-Commit-Position: refs/heads/master@{#430974}

Powered by Google App Engine
This is Rietveld 408576698