Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2491563002: Change ScreenAndroid and ScreenIos to use ScreenBase and DisplayList. (Closed)

Created:
4 years, 1 month ago by riajiang
Modified:
4 years, 1 month ago
Reviewers:
sadrul
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ScreenAndroid and ScreenIos to use ScreenBase and DisplayList. BUG=none, related to https://codereview.chromium.org/2361283002 TEST=covered by tests Committed: https://crrev.com/34975fc42d7a460c61fb6f13b93e2dc5db96357e Cr-Commit-Position: refs/heads/master@{#431351}

Patch Set 1 #

Patch Set 2 : public #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -79 lines) Patch
M ui/display/android/screen_android.cc View 2 chunks +12 lines, -37 lines 0 comments Download
M ui/display/ios/screen_ios.mm View 1 2 chunks +13 lines, -42 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
riajiang
Hi sadrul, PTAL. Thanks!
4 years, 1 month ago (2016-11-09 19:06:50 UTC) #7
sadrul
lgtm
4 years, 1 month ago (2016-11-10 20:13:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491563002/10003
4 years, 1 month ago (2016-11-10 21:04:05 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:10003)
4 years, 1 month ago (2016-11-10 21:10:41 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 21:23:35 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34975fc42d7a460c61fb6f13b93e2dc5db96357e
Cr-Commit-Position: refs/heads/master@{#431351}

Powered by Google App Engine
This is Rietveld 408576698