Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2491553002: ABANDONED CL: Disambiguate content_browsertests target. (Closed)

Created:
4 years, 1 month ago by Łukasz Anforowicz
Modified:
4 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews, jam, darin-cc_chromium.org, jbudorick, alexmos, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ABANDONED CL: Disambiguate content_browsertests target. After r430603 there was an ambiguity (when target_os = "android") whether content_browsertests refers to //content/test:content_browsertests or to //testing/buildbot/filters:content_browsertests. This CL resolves this ambiguity by renaming //testing/buildbot/filters:content_browsertests to //testing/buildbot/filters:content_browsertests_filters (and also does a similar change for //testing/buildbot/filters:browser_tests). BUG=663785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/filters/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
Łukasz Anforowicz
brettw@, could you please take a look?
4 years, 1 month ago (2016-11-09 18:33:15 UTC) #4
Łukasz Anforowicz
4 years, 1 month ago (2016-11-09 20:32:20 UTC) #7
On 2016/11/09 18:33:15, Łukasz Anforowicz wrote:
> brettw@, could you please take a look?

Actually, please just ignore this CL.  amineer@ pointed out that
https://crbug.com/663785 also affects Canary and Dev builds - I've just reverted
the previous CL.  This means that I'll abandon the CL under review and instead
put together a reland that combines both the reverted CL and the disambiguation
of the content_browsertests target.

Powered by Google App Engine
This is Rietveld 408576698