Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2491533002: Don't ovewrite method types of a resynthesized library in TypeResolverVisitor. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't ovewrite method types of a resynthesized library in TypeResolverVisitor. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/221ff0beaeb7fe5d04895f482f41736a58447fc1

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +1 line, -1 line 1 comment Download
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +10 lines, -0 lines 1 comment Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 2 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 1 month ago (2016-11-09 15:53:20 UTC) #1
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-09 16:25:23 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/2491533002/diff/1/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/2491533002/diff/1/pkg/analyzer/lib/src/generated/resolver.dart#newcode9767 pkg/analyzer/lib/src/generated/resolver.dart:9767: // See also dartbug.com/27482 for separating static and ...
4 years, 1 month ago (2016-11-09 16:47:22 UTC) #3
Paul Berry
https://codereview.chromium.org/2491533002/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart File pkg/analyzer/lib/src/dart/analysis/driver.dart (right): https://codereview.chromium.org/2491533002/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart#newcode69 pkg/analyzer/lib/src/dart/analysis/driver.dart:69: static const int DATA_VERSION = 3; Note: I just ...
4 years, 1 month ago (2016-11-09 17:14:05 UTC) #4
scheglov
4 years, 1 month ago (2016-11-09 18:24:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
221ff0beaeb7fe5d04895f482f41736a58447fc1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698