NaCl: Update revision in DEPS, r13018 -> r13078.

NaCl: Update revision in DEPS, r13018 -> r13078.

Chromium NaCl scripts now uses package_version to extract.

Now that we have split up the toolchain into multiple tars, we should
use the package versioning script to manage which tars to extract.
Unfortunately, currently the SDK uses different directory names compared
to what the NaCl toolchain directories normally use, so we also must map
and move the toolchain directories to the SDK ones.

BUG=365817
TEST= trybots

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266284

[David Yen, 2014-04-24 21:26:55]

After some investigation, Mark is convinced if we bump the NaCl rev to a more
recent version the NonSFI tests will pass now. This is the same CL as 

https://codereview.chromium.org/235603004/

except the revision has been bumped to 13078.

I will need LGTM's from everyone again.

[Mark Seaborn, 2014-04-24 21:35:52]

mac_nacl_sdk fails with:

.../x86_64-nacl/bin/ld: cannot find crti.o: No such file or directory

(from
http://build.chromium.org/p/tryserver.chromium/builders/mac_nacl_sdk/builds/1...)

[David Yen, 2014-04-24 21:38:47]

On 2014/04/24 21:35:52, Mark Seaborn wrote:
> mac_nacl_sdk fails with:
> 
> .../x86_64-nacl/bin/ld: cannot find crti.o: No such file or directory
> 
> (from
>
http://build.chromium.org/p/tryserver.chromium/builders/mac_nacl_sdk/builds/1...)

That's caused by that machine being in a bad state, I've seen this before and
have worked with Brad in trying to figure out what has happened to the buildbot
but have not been able to figure it out. I'll clean out the gyp directory and
run it again.

[Mark Seaborn, 2014-04-24 21:48:55]

On 2014/04/24 21:38:47, David Yen wrote:
> On 2014/04/24 21:35:52, Mark Seaborn wrote:
> > mac_nacl_sdk fails with:
> > 
> > .../x86_64-nacl/bin/ld: cannot find crti.o: No such file or directory
> > 
> > (from
> >
>
http://build.chromium.org/p/tryserver.chromium/builders/mac_nacl_sdk/builds/1...)
> 
> That's caused by that machine being in a bad state, I've seen this before and
> have worked with Brad in trying to figure out what has happened to the
buildbot
> but have not been able to figure it out. I'll clean out the gyp directory and
> run it again.

OK, LGTM then, assuming the rest of the change is the same as in the earlier
version.

[jvoung (off chromium), 2014-04-24 22:02:35]

lgtm

[David Yen, 2014-04-24 23:54:56]

On 2014/04/24 22:02:35, jvoung (cr) wrote:
> lgtm

Now linux_chromium_chromeos_rel no longer works, does anyone know what is going
on there?

[jvoung (off chromium), 2014-04-25 00:01:14]

On 2014/04/24 23:54:56, David Yen wrote:
> On 2014/04/24 22:02:35, jvoung (cr) wrote:
> > lgtm
> 
> Now linux_chromium_chromeos_rel no longer works, does anyone know what is
going
> on there?

Not sure, but the test runner also shows "browser_tests (without patch)" has
similar failures as "(with patch)".

[Mark Seaborn, 2014-04-25 00:02:32]

On 24 April 2014 16:54, <dyen@chromium.org> wrote:

> On 2014/04/24 22:02:35, jvoung (cr) wrote:
>
>> lgtm
>>
>
> Now linux_chromium_chromeos_rel no longer works, does anyone know what is
> going
> on there?


Since various non-NaCl-related tests fail there, it's probably not a
problem with your change.

I don't think the (non-daisy) chromeos trybots have any differences from
the normal Linux trybots that are relevant to NaCl, so I suspect you can
safely ignore those failures.

Mark

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Mark Seaborn, 2014-04-25 01:27:42]

The CQ bit was checked by mseaborn@chromium.org

[commit-bot: I haz the power, 2014-04-25 02:04:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dyen@chromium.org/249153003/20007

[commit-bot: I haz the power, 2014-04-25 02:21:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 02:21:40]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[David Yen, 2014-04-25 16:50:11]

It looks like we still need a LGTM from either Brad or Noel, I added Noel as a
reviewer now since he is back.

[bradnelson, 2014-04-25 18:34:04]

lgtm

[David Yen, 2014-04-25 18:36:10]

The CQ bit was checked by dyen@chromium.org

[David Yen, 2014-04-25 20:21:37]

The CQ bit was unchecked by dyen@chromium.org

[David Yen, 2014-04-25 20:21:47]

The CQ bit was checked by dyen@chromium.org

[commit-bot: I haz the power, 2014-04-25 21:48:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dyen@chromium.org/249153003/20007

[David Yen, 2014-04-25 21:49:29]

Does anyone know why the commit queue is not working? I tried selecting it twice
already.

[David Yen, 2014-04-25 21:50:12]

Oh nevermind, it started now. I wonder if it's because I published a comment.

[commit-bot: I haz the power, 2014-04-25 23:30:28]

Change committed as 266284

[tonyg, 2014-04-26 01:53:46]

A revert of this CL has been created in
https://codereview.chromium.org/250933006/ by tonyg@chromium.org.

The reason for reverting is: Breaks official build on chromium.perf waterfall.

FAILED: cd ../../native_client/src/shared/gio; export
BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release;
export CONFIGURATION=Release; export PRODUCT_NAME=gio_lib; export
SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk;
export
SRCROOT=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/../../native_client/src/shared/gio;
export SOURCE_ROOT="${SRCROOT}"; export
TARGET_BUILD_DIR=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release;
export TEMP_DIR="${TMPDIR}";python ../../../../native_client/build/build_nexe.py
-t ../../../../out/Release/gen/sdk/ --arch x86-32 --build glibc_nso --root
../../../.. --name ../../../../out/Release/gen/tc_glibc/lib32/libgio.so --objdir
../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib
"--include-dirs=../../../../out/Release/gen/tc_glibc/include ../../../..
../../../src/third_party ../../../.." "--compile_flags=-m32 -fPIC
-fomit-frame-pointer -fasynchronous-unwind-tables  -O2 -g -Wall
-fdiagnostics-show-option -Werror " --gomadir "" "--defines=__linux__
\"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" \"_GNU_SOURCE=1\"
\"_BSD_SOURCE=1\" \"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\"
\"DYNAMIC_ANNOTATIONS_ENABLED=1\" \"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\"
\"NACL_BUILD_ARCH=x86\" V8_DEPRECATION_WARNINGS
BLINK_SCALE_FILTERS_AT_RECORD_TIME \"NACL_LINUX=0\" \"NACL_ANDROID=0\"
\"NACL_OSX=1\" \"NACL_WINDOWS=0\" GOOGLE_CHROME_BUILD ENABLE_RLZ
\"USE_LIBJPEG_TURBO=1\" ENABLE_ONE_CLICK_SIGNIN \"ENABLE_REMOTING=1\"
\"ENABLE_WEBRTC=1\" USE_PROPRIETARY_CODECS ENABLE_PEPPER_CDMS
ENABLE_CONFIGURATION_POLICY ENABLE_INPUT_SPEECH ENABLE_NOTIFICATIONS
\"ENABLE_HIDPI=1\" DISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY
SYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE \"ENABLE_EGLIMAGE=1\"
\"ENABLE_TASK_MANAGER=1\" \"ENABLE_EXTENSIONS=1\"
\"ENABLE_PLUGIN_INSTALLATION=1\" \"ENABLE_PLUGINS=1\"
\"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\" \"ENABLE_AUTOFILL_DIALOG=1\"
\"ENABLE_BACKGROUND=1\" \"ENABLE_GOOGLE_NOW=1\" \"CLD_VERSION=2\"
\"ENABLE_FULL_PRINTING=1\" \"ENABLE_PRINTING=1\" \"ENABLE_SPELLCHECK=1\"
\"ENABLE_CAPTIVE_PORTAL_DETECTION=1\" \"ENABLE_APP_LIST=1\"
\"ENABLE_SETTINGS_APP=1\" \"ENABLE_MANAGED_USERS=1\"
\"ENABLE_SERVICE_DISCOVERY=1\" \"NACL_TARGET_SUBARCH=32\"
\"NACL_TARGET_ARCH=x86\" \"NACL_BUILD_SUBARCH=32\" \"NACL_BUILD_ARCH=x86\""
"--link_flags=-m32 -B../../../../out/Release/gen/tc_glibc/lib32  "
"--source-list=../../../../out/gypfiles/native_client/src/shared/gio/glibc-x86-32-so.gio_lib.source_list.gypcmd"
/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/bin/ld:
cannot find crti.o: No such file or directory
/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/bin/ld:
cannot find crtbeginS.o: No such file or directory
collect2: ld returned 1 exit status
../../../../out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/x86_64-nacl-g++ -o
../../../../out/Release/gen/tc_glibc/lib32/libgio.so -Wl,--as-needed
../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio_mem.o
../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio.o
../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gprintf.o
../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio_mem_snapshot.o
-m32 -B../../../../out/Release/gen/tc_glibc/lib32 -shared -Wl,-soname,libgio.so
FAILED: Command
'['../../../../out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/x86_64-nacl-g++',
'-o', '../../../../out/Release/gen/tc_glibc/lib32/libgio.so', '-Wl,--as-needed',
'../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio_mem.o',
'../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio.o',
'../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gprintf.o',
'../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio_mem_snapshot.o',
'-m32', '-B../../../../out/Release/gen/tc_glibc/lib32', '-shared',
'-Wl,-soname,libgio.so']' returned non-zero exit status 1
FAILED: cd ../../native_client/src/shared/gio; export
BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release;
export CONFIGURATION=Release; export PRODUCT_NAME=gio_lib; export
SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk;
export
SRCROOT=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/../../native_client/src/shared/gio;
export SOURCE_ROOT="${SRCROOT}"; export
TARGET_BUILD_DIR=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release;
export TEMP_DIR="${TMPDIR}";python ../../../../native_client/build/build_nexe.py
-t ../../../../out/Release/gen/sdk/ --arch x86-64 --build glibc_nso --root
../../../.. --name ../../../../out/Release/gen/tc_glibc/lib64/libgio.so --objdir
../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib
"--include-dirs=../../../../out/Release/gen/tc_glibc/include ../../../..
../../../src/third_party ../../../.." "--compile_flags=-m64 -fPIC
-fomit-frame-pointer -fasynchronous-unwind-tables  -O2 -g -Wall
-fdiagnostics-show-option -Werror " --gomadir "" "--defines=__linux__
\"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" \"_GNU_SOURCE=1\"
\"_BSD_SOURCE=1\" \"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\"
\"DYNAMIC_ANNOTATIONS_ENABLED=1\" \"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\"
\"NACL_BUILD_ARCH=x86\" V8_DEPRECATION_WARNINGS
BLINK_SCALE_FILTERS_AT_RECORD_TIME \"NACL_LINUX=0\" \"NACL_ANDROID=0\"
\"NACL_OSX=1\" \"NACL_WINDOWS=0\" GOOGLE_CHROME_BUILD ENABLE_RLZ
\"USE_LIBJPEG_TURBO=1\" ENABLE_ONE_CLICK_SIGNIN \"ENABLE_REMOTING=1\"
\"ENABLE_WEBRTC=1\" USE_PROPRIETARY_CODECS ENABLE_PEPPER_CDMS
ENABLE_CONFIGURATION_POLICY ENABLE_INPUT_SPEECH ENABLE_NOTIFICATIONS
\"ENABLE_HIDPI=1\" DISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY
SYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE \"ENABLE_EGLIMAGE=1\"
\"ENABLE_TASK_MANAGER=1\" \"ENABLE_EXTENSIONS=1\"
\"ENABLE_PLUGIN_INSTALLATION=1\" \"ENABLE_PLUGINS=1\"
\"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\" \"ENABLE_AUTOFILL_DIALOG=1\"
\"ENABLE_BACKGROUND=1\" \"ENABLE_GOOGLE_NOW=1\" \"CLD_VERSION=2\"
\"ENABLE_FULL_PRINTING=1\" \"ENABLE_PRINTING=1\" \"ENABLE_SPELLCHECK=1\"
\"ENABLE_CAPTIVE_PORTAL_DETECTION=1\" \"ENABLE_APP_LIST=1\"
\"ENABLE_SETTINGS_APP=1\" \"ENABLE_MANAGED_USERS=1\"
\"ENABLE_SERVICE_DISCOVERY=1\" \"NACL_TARGET_SUBARCH=32\"
\"NACL_TARGET_ARCH=x86\" \"NACL_BUILD_SUBARCH=32\" \"NACL_BUILD_ARCH=x86\""
"--link_flags=-B../../../../out/Release/gen/tc_glibc/lib64  "
"--source-list=../../../../out/gypfiles/native_client/src/shared/gio/glibc-x86-64-so.gio_lib.source_list.gypcmd"
/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/bin/ld:
cannot find crti.o: No such file or directory
/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/bin/ld:
cannot find crtbeginS.o: No such file or directory
collect2: ld returned 1 exit status
../../../../out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/x86_64-nacl-g++ -o
../../../../out/Release/gen/tc_glibc/lib64/libgio.so -Wl,--as-needed
../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio_mem.o
../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio.o
../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gprintf.o
../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio_mem_snapshot.o
-B../../../../out/Release/gen/tc_glibc/lib64 -shared -Wl,-soname,libgio.so
FAILED: Command
'['../../../../out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/x86_64-nacl-g++',
'-o', '../../../../out/Release/gen/tc_glibc/lib64/libgio.so', '-Wl,--as-needed',
'../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio_mem.o',
'../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio.o',
'../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gprintf.o',
'../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio_mem_snapshot.o',
'-B../../../../out/Release/gen/tc_glibc/lib64', '-shared',
'-Wl,-soname,libgio.so']' returned non-zero exit status 1
ninja: build stopped: subcommand failed.

http://build.chromium.org/p/chromium.perf/builders/Mac%20Builder/builds/60425....